Comments (11)
So somewhere in the chain you want to make sure that all coordinates are consistent, right?
I agree, see my comments here ESMValGroup/ESMValCore#956 (comment)
from esmvaltool_sample_data.
Is this picked up by the cmor checks/fixes if the data is loaded in ESMValTtool?
from esmvaltool_sample_data.
no - why would it be? It's a valid plev
coordinate wrt CMOR standards:
DimCoord(array([100000.00000001, 92500.00000001]), bounds=array([[103750.00000001, 96250.00000001],
[ 96250.00000001, 88750.00000001]]), standard_name='air_pressure', units=Unit('Pa'), long_name='pressure', var_name='plev', attributes={'positive': 'down'})
is a perfectly fine coordinate 😃
from esmvaltool_sample_data.
note that this doesn't fix ESMValGroup/ESMValCore#956 - there is no need for a fix for that perse, it behaves as it should (I'll post a comment there); also this is not an issue 👍
from esmvaltool_sample_data.
Okay so maybe it's valid, but it's not a standard level. If you try to join two cubes in Iris where one of them has plev = [100000.00000001, 92500.00000001]
and the other has plev=[100000., 92500.]
, it will fail because it cannot merge cubes with different coordinates. This makes a lot of sense to me.
So somewhere in the chain you want to make sure that all coordinates are consistent, right?
from esmvaltool_sample_data.
what do you mean they're not standard? ie they're not plev17
or plev19
? That's true, but Z-data can be whatever the model outputs, as long as the units, standard name and order in which the points are (positive: up
or down
depending what type of coord is) are CMOR-standard all's fine. Note that iris' restriction applies to any difference in coordinate points values and attributes, no matter if they're CMOR-compliant or not, that's a self-imposed standard that the iris devs have implemented so that there are no unexpected issues, which in some cases, like here, is useful; in other cases we need to go around it and shunt it since it's a nuisance
from esmvaltool_sample_data.
Is this picked up by the cmor checks/fixes if the data is loaded in ESMValTtool?
Yes, this should issue a warning coming from here: https://github.com/ESMValGroup/ESMValCore/blob/b632f9ac7172a91b52fe91264f37a2ce3e13ac3e/esmvalcore/cmor/check.py#L633
from esmvaltool_sample_data.
I made a PR that removes the deviating datasets from the repo, since we do not use the esmvalcore machinery to go through the fixes. See #21
from esmvaltool_sample_data.
I'm not entirely sure if this is a bad enough error for removing the datasets. If I understood it correctly, the plev
coordinates are the same up to the numerical precision of the floating point number used to represent the coordinate data, right?
from esmvaltool_sample_data.
iris will say they are different. If these are still included, ESMValGroup/ESMValCore#968 will fail.
from esmvaltool_sample_data.
Yes, I think that is a usability problem of iris, because to a scientist this doesn't make sense, from a physical point of view they are the same. It would be good if the ESMValCore is able to deal with this kind of technical detail without bothering the scientist users with it.
from esmvaltool_sample_data.
Related Issues (11)
- Populate repository with data
- Support tests for multimodel statistics preprocessor function HOT 2
- Some datasets have multiple versions HOT 1
- Datasets have different calendars / shapes HOT 3
- Add unit tests for loader functions
- How to use this dataset in ESMValTool projects? HOT 1
- Add github actions for pytest
- Installation instructions
- Dataset contains very large unmasked value HOT 1
- Look into using pooch HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from esmvaltool_sample_data.