Comments (2)
Some relevant notes from Slack:
As far as I can tell, there are no significant downstream problems with the empty _type
attr. The only thing I can really find is that if you call .to_json()
on that new empty TimeSeries
you’re going to get some very bare bones output:
{"utc": true, "points": [], "name": "Sensor values", "columns": []}
The columns list can’t be built because 1) the _type
is invalid and 2) there are no data.
It potentially impacts Collection.at()
as well, but at least in the python version, type being None still won’t impact anything because since the series is empty, trying to index the empty event list it will fuck up first:
try:
return self._type(self._event_list[pos])
except IndexError:
raise CollectionException('invalid index given to at()')
I would say that the undefined event is a pretty safe change.
It isn’t about returning a good object, it’s just so code doesn’t blow up when people manipulate an empty time series and not hunting down a bunch of places in the code where this could manifest and explode.
from pond.
These changes are rolled into the v0.7 branch now.
from pond.
Related Issues (20)
- Timeseries with names containing dots are not compatible with fieldSpecs
- fixedWindowRollup of less than 1 second HOT 3
- Strong-type data points, avoid magic strings HOT 3
- How to use a Rolling/Sliding Window HOT 1
- How to append new events? HOT 4
- Suggested addition to rollup callendar intervals
- Remove moment.js to improve bundle sizes HOT 2
- TimeEvent implementation does not exist in index.d.ts HOT 5
- Displaying a specific column from TS
- TimeSeries.columns() throws iterator exception instead of returning empty array
- A time-series database? HOT 1
- Time-Index in Milliseconds? HOT 1
- duplicate *events def in timeseries.js v0.9.0
- Filter TimeSeries in pond 0.9
- Sampling of TimeSeries
- one of my favourite projects on github
- Creating a TimeSeries of IndexedEvent with indexes before epoch throws TypeError
- Use Generator for events generator function return type
- Property 'range' does not exist on type 'TimeSeries' in v0.9.0
- Index.getIndexString parameter definition missed in v0.9.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pond.