Nightly CI is broken about esp-hal

[bjoernQ]

Maybe it would be sufficient to only do Clippy checks using the latest nightly, or am I missing something?

[danclive]

About the recent failure of CI:

    Compiling examples v0.0.0 (/home/runner/work/esp-hal/esp-hal/examples)
error: concrete type differs from previous defining opaque type use
  --> src/bin/embassy_usb_serial_jtag.rs:27:1
   |
27 | #[embassy_executor::task]
   | ^^^^^^^^^^^^^^^^^^^^^^^^^ expected `writer::Fut`, got `impl Future<Output = ()>`
   |
note: previous use here
  --> src/bin/embassy_usb_serial_jtag.rs:27:1

It seems to be related to the "nightly" features of embassy-executor.

esp-hal/examples/Cargo.toml

Line 14 in 1846543

embassy-executor = { version = "0.5.0", features = ["nightly"] }

If the nightly features are removed, the compilation can succeed. This may be due to the recent Rust Nightly having a destructive impact on embassy-executor-macros.

https://github.com/embassy-rs/embassy/blob/ea25112f7d1ce27a7216ce6c3aab983dc3a0d7c0/embassy-executor-macros/src/macros/task.rs#L93-L101

[MabezDev]

That is another option, we could use stable + task arenas instead of TAIT.

[jessebraham]

That is another option, we could use stable + task arenas instead of TAIT.

I guess this is our only real option. Shame, I can see this causing problems, but our hands are tied. It's not reasonable to only support one nightly release IMO.