GithubHelp home page GithubHelp logo

Comments (7)

jabadia avatar jabadia commented on May 26, 2024

related to discussion in #14

from angular-esri-map.

tomwayson avatar tomwayson commented on May 26, 2024

@jabadia I agree that I would prefer not to include the derived files in the repo, but if we want to use bower as the means of distributing the files, then we need to at least include dist (sad face).

I'd like to at least not include two copies of the built files, so I'm thinking ways to base gulp serve and gh-pages off the dist folder.

from angular-esri-map.

patrickarlt avatar patrickarlt commented on May 26, 2024

The best solution to this I have found is Leaflets publish.sh file https://github.com/Leaflet/Leaflet/blob/master/build/publish.sh.

When you build it force checks in the built files in to a temporary release branch and tags the repo at that point then the temp branch is deleted. This means that the only point in which the built files are in the repo is at that tag.

from angular-esri-map.

tomwayson avatar tomwayson commented on May 26, 2024

And of course, since I used gulp, we can't take advantage of grunt-releaseable w/o either adding grunt, or creating gulp-releasable.

from angular-esri-map.

tomwayson avatar tomwayson commented on May 26, 2024

So, ignoring the built files under the app folder (#22) was half the solution. Ultimately, I think we should a publish task like @patrickarlt suggests. The question is if we need to do this before we the first public release.

I will try to take a look at this when I get a chance, but I don't know if this should be something that prevents us from going live.

In other words do we keep this in the Beta 1 milestone?

from angular-esri-map.

tomwayson avatar tomwayson commented on May 26, 2024

Looks like Esri leaflet has moved on from grunt-releasable to using custom publish/build scripts with gh-release. gh-release looks pretty 🔥, and seems like it could be useful in solving this issue.

from angular-esri-map.

tomwayson avatar tomwayson commented on May 26, 2024

Resolved (finally!) by 080f5a0

from angular-esri-map.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.