GithubHelp home page GithubHelp logo

Comments (6)

mikesherov avatar mikesherov commented on July 19, 2024 1

@fitzgen thanks for contributing! We can't break the web, so closing this issue.

from estree.

dherman avatar dherman commented on July 19, 2024

I am pretty confident changing error stack indices would break the web.

from estree.

nzakas avatar nzakas commented on July 19, 2024

👎 If such compatibility is an issue, it can be handled downstream by tools.

from estree.

RReverser avatar RReverser commented on July 19, 2024

@nzakas 👍 I don't see reasons to break established logic and tools that rely on it.

from estree.

getify avatar getify commented on July 19, 2024

Not disagreeing with the resolution here. I also think we should leave them 0-based. Such re-mapping of line numbers or column numbers is entirely in the realm of tools and not standards. IIRC, JSLint awhile back begrudgingly added a feature to change the numbering.

But the "would break the web" assertion is not terribly obvious. I've tried for a bit to come up with many practical use-cases where that's true and I can't. We might want to add more detail here, or somewhere, to document for posterity why that would be the case.

from estree.

mikesherov avatar mikesherov commented on July 19, 2024

"Break the web" is generic shorthand for "break all downstream consumers of esprima, acorn, and Spidermonkey".

from estree.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.