Comments (6)
@fitzgen thanks for contributing! We can't break the web, so closing this issue.
from estree.
I am pretty confident changing error stack indices would break the web.
from estree.
👎 If such compatibility is an issue, it can be handled downstream by tools.
from estree.
@nzakas 👍 I don't see reasons to break established logic and tools that rely on it.
from estree.
Not disagreeing with the resolution here. I also think we should leave them 0-based. Such re-mapping of line numbers or column numbers is entirely in the realm of tools and not standards. IIRC, JSLint awhile back begrudgingly added a feature to change the numbering.
But the "would break the web" assertion is not terribly obvious. I've tried for a bit to come up with many practical use-cases where that's true and I can't. We might want to add more detail here, or somewhere, to document for posterity why that would be the case.
from estree.
"Break the web" is generic shorthand for "break all downstream consumers of esprima, acorn, and Spidermonkey".
from estree.
Related Issues (20)
- Add async keyword to MethodDefinition
- Add `shorthand` property to `ExportSpecifier` and `ImportSpecifier`? HOT 8
- Improving the AST for computed-name properties HOT 4
- new syntax for import assertions HOT 2
- import / export should also allow string literals
- fix-request: Missing interface causing eslint incompatibilities in older versions HOT 5
- extend interface & `<:` HOT 2
- ESTreeParser
- Literal of ES2020 Violates the Principle of Unique HOT 1
- BinaryExpression Tree Balance HOT 2
- AST definition for Stage 4 Hashbang Grammer? HOT 2
- Add `raw` to `Identifier`? HOT 6
- `AccessorProperty` vs `AccessorPropertyDefinition` HOT 5
- Not disagreeing with the resolution here. I also think we should leave them 0-based. Such re-mapping of line numbers or column numbers is entirely in the realm of tools and not standards. IIRC, JSLint awhile back begrudgingly added a feature to change the numbering.
- Clearify how `BigIntLiteral.bigint` should represent HOT 5
- Make `NullLiteral` check easier HOT 4
- add using keyword to spec HOT 2
- Rename `assertions`/`attributes` in `ImportExpression` HOT 5
- AST of import declaration without attributes HOT 5
- Decorators on exported classes HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from estree.