Add utility checking functions for determining if a type is known. about eth-abi

[carver]

👍 for adding both

[davesque]

So that would just be something like this?

def is_valid_type(self, typ):
    if coder_found_for_type:
        return True
    else:
        return False

def validate_type(self, typ):
    if coder_found_for_type:
        return
    else:
        raise ValidationError(...)

[pipermerriam]

Yeah, those implementations seem on-par with what I was thinking. Worth evaluating whether those would suffice for the linked eth-account issue since that was the primary motivation for this.

[davesque]

I was looking into implementing a has_encoder method on the ABIRegistry class just now. That would return True or False depending on if a given type string has an encoder in the registry. However, it's making me realize that the granularity of errors throw by the PredicateMapping class isn't great. Ideally, I would have a PredicateMappingError class and at least two subclasses of that for the purposes of that new method. Those would be something like NoEntriesFound and MultipleEntriesFound. Then I could catch the NoEntriesFound error specifically in the has_encoder method. I know that you two have voiced a preference for using built-in error types but, in this case, I don't think that's going to work terribly well. I'll just go ahead and proceed with custom error types unless I hear any strong objections to that plan.

[davesque]

Or, we could subclass ValueError to keep things backwards compatible but that just feels weird.

[pipermerriam]

You can do the subclass approach with the plan to break that link in the next major version bump. In general I'm a fan of custom exceptions for things that a user would want to catch and only using things like ValueError or TypeError for things that are true programmer mistakes and not things that they should encounter during runtime (and thus that they shouldn't need to differentiate between exception types)

[davesque]

Just made PR #128 to fix this.

[fubuloubu]

#128 was merged, close this?

Note, I tracked this down via the following comment:
https://github.com/ethereum/eth-account/blob/a1e5ab2400ae6ed70d91a1226ec3643d27b29e56/eth_account/_utils/structured_data/hashing.py#L100

[davesque]

@fubuloubu Ahh, yeah. Thanks!