GithubHelp home page GithubHelp logo

Comments (5)

davesque avatar davesque commented on July 3, 2024 1

Sure: e043f73

from eth-abi.

davesque avatar davesque commented on July 3, 2024

Looks like some tests based on RNG are failing. I guess my method for ensuring the same seed isn't working (or stopped working?). Either way, I'll take a look.

from eth-abi.

davesque avatar davesque commented on July 3, 2024

I went ahead and just removed the lines which generate test examples. I think it's clear enough what the code is doing without it. I also went cowboy and just merged it straight into master so another PR I just made would stop failing. Sorry! :)

from eth-abi.

carver avatar carver commented on July 3, 2024

Yikes! Not sure the situation justified that, I think you would have gotten pretty quick 👍 on merging a PR.

Anyhow, can you link the commit in this issue?

from eth-abi.

davesque avatar davesque commented on July 3, 2024

As you can see, I just deleted some lines from a doctest. I dunno, I assumed this fits under the "pedantic to request approval" category. :/

from eth-abi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.