Reconsider certain uses of property testing about eth-abi

[carver]

No objection here. I find it very difficult to parse those tests for correctness, as is.

[davesque]

Thoughts on this @pipermerriam ?

[pipermerriam]

Agreed. Writing all of those tests was largely an experiment and I'd say it's failed as 1) they are very hard to read, and 2) they are effectively a second implementation of the logic (like you said).

[pipermerriam]

Simplifying them to something like the following might make a lot of sense:

• if it fails decoding: no assertions (unless we can think of good ones)
• assertions that numeric values are strictly positive for unsigned types.
• maybe assertions that decoded values are negative if we can reliably look at the right bit.
• assertions that numeric values are in the appropriate range for the given type.
• assertions that the value is an integer for types which should only yield integers.
• assertions that the resulting type is of the appropriate type for the decoder.
• assertions that on encoding the resulting value is the right length for any fixed length encoders.