GithubHelp home page GithubHelp logo

Comments (8)

davesque avatar davesque commented on July 3, 2024 1

@carver My thinking was that this could be something that gets included in v2.

from eth-abi.

pipermerriam avatar pipermerriam commented on July 3, 2024 1

If web3 is using this we need to remove that since this API is under utils and thus, is considered private. I don't think this requires a deprecation, but we should be careful to not break web3 as we fix this.

from eth-abi.

carver avatar carver commented on July 3, 2024

It's used a few places in web3, so that's one place to try out the new approach.

from eth-abi.

davesque avatar davesque commented on July 3, 2024

@pipermerriam @carver

Another behavior that I'd like to change, which is related to all of this, is that the encode_single and decode_single functions accept either a type string or a type tuple (with "base", "sub", and "arrlist" components). If a type tuple is provided, the collapse_type utility function is used to convert it to a type string.

I'd like to remove the collapse_type function and make it so that the encode_single and decode_single functions expect a type string and nothing else. My motivation with this is to make the API simpler and less magical.

I feel like I might have had a previous discussion about this with @carver in which he may have asked to leave this behavior unchanged. Sorry if I'm forgetting this. If that is the case, would it be possible to simply move the collapse_type function into web3 or wherever it's needed and apply it manually to type string data that is headed for encode_single or decode_single?

from eth-abi.

davesque avatar davesque commented on July 3, 2024

^^^ Actually, I'll make another issue ticket for the last comment.

from eth-abi.

davesque avatar davesque commented on July 3, 2024

I went ahead and made PR #87 for when we decide to include this.

from eth-abi.

dylanjw avatar dylanjw commented on July 3, 2024

I can open a PR in web3 to replace process_type with grammar.parse

from eth-abi.

davesque avatar davesque commented on July 3, 2024

Merged PR #87 .

from eth-abi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.