GithubHelp home page GithubHelp logo

Comments (12)

cdetrio avatar cdetrio commented on July 26, 2024 1

Why not sign the tx in the test runner and then send it to the client with eth_sendRawTransaction? Fewer RPC methods makes it easier to support more clients.

from retesteth.

winsvega avatar winsvega commented on July 26, 2024

rename to test_signAndSendTransaction by proposal of @gumb0?

from retesteth.

pirapira avatar pirapira commented on July 26, 2024

test_signAndAppendTransaction?

from retesteth.

chfast avatar chfast commented on July 26, 2024

secretKey -> privateKey?

from retesteth.

winsvega avatar winsvega commented on July 26, 2024

test files has this field named "secretKey". that might be confusing but doable

from retesteth.

chfast avatar chfast commented on July 26, 2024

The "secret key" is confusing by itself. Nobody knows what it is except ~5 people.

from retesteth.

winsvega avatar winsvega commented on July 26, 2024

that would require test runner to implement crypto libs, making it heavier

from retesteth.

pirapira avatar pirapira commented on July 26, 2024

@winsvega why? There is signTransaction RPC method.

from retesteth.

winsvega avatar winsvega commented on July 26, 2024

ok. then I should study how it works. so maybe there is no need in this method.
I see, I've remembered.
@pirapira is there a method to add account by private key via RPC ? signTransaction wont work if there is no account

from retesteth.

winsvega avatar winsvega commented on July 26, 2024

@pirapira @cdetrio @holiman
ok. what if instead of adding this new method. there would be a
test_registerAccount(Privatekey)

then it would be possible to use existing signTransaction and sendRawTransaction

from retesteth.

winsvega avatar winsvega commented on July 26, 2024

replacing this requirement with standart eth_sendRawTransaction

from retesteth.

winsvega avatar winsvega commented on July 26, 2024

https://github.com/ethereum/retesteth/wiki/RPC-Methods

from retesteth.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.