GithubHelp home page GithubHelp logo

Comments (7)

holgerd77 avatar holgerd77 commented on June 19, 2024 7

New npm release is out: https://www.npmjs.com/package/ethereumjs-abi

Sorry for the delay, will close now.

from ethereumjs-abi.

marekkirejczyk avatar marekkirejczyk commented on June 19, 2024 4

It works in code downloaded for the master. I think it might be a matter of releasing new version.

Checked: The code on master and in latest version (0.6.4) differ in function solidityPack.
The problem is in the solidityPack function, which in 0.6.4 returns only zeros after first bytes32 was encoded.
Version on master works fine.

from ethereumjs-abi.

thisbejim avatar thisbejim commented on June 19, 2024 4

Also confirming this issue, you must install from master for soliditySHA3 to work properly. I recommend publishing the latest version to npm.

from ethereumjs-abi.

D-Nice avatar D-Nice commented on June 19, 2024 2

The issue is with any static bytes type, on the package published on npm.

It has to do with the solidityPack function, which in the npm package does a return

      return utils.setLengthRight(value, size)

while in this repo it seems fixed and actually pushes to the ret array instead:
https://github.com/ethereumjs/ethereumjs-abi/blob/master/lib/index.js#L453

Requesting for an update also here
#54

from ethereumjs-abi.

gkucmierz avatar gkucmierz commented on June 19, 2024

Anyone can resolve that?

from ethereumjs-abi.

D-Nice avatar D-Nice commented on June 19, 2024

pinging @axic

from ethereumjs-abi.

marekkirejczyk avatar marekkirejczyk commented on June 19, 2024

We use web3js in beta:
https://web3js.readthedocs.io/en/1.0/web3-utils.html#soliditysha3

from ethereumjs-abi.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.