Comments (4)
You are correct. At this time I do not support characters outside of /^[0-9a-z-]*$/.
I can add a flag to the command line tool to override this though, if it is a feature people really want, but there are caveats that need to be understood.
It still remains to be seen how well support is going to be (at least in the near future) of names outside of this, and a lot of additional security concerns come up as well. Also, the library becomes much larger as it must contain a large database of all UTF-8 characters and how they relate to each other.
Depending on your browser, this may show up as apple.com: https://www.xn--80ak6aa92e.com/
Just as a quick example of the dangers of allowing the entire UTF-8 set; which gets converted into puny code, allowing homographs.
from ethers-ens.
didn't realize the puny code urls allow homographs!
I just noticed that Mist/geth allow umlauts but not all UTF characters... no idea how that works... but I was hoping it would work better in ENS than in DNS world. Allowing for normal german spelling. also for personal German or french names (for personal wallets e.g.).
from ethers-ens.
"I can add a flag to the command line tool to override this though"
Is this still an option?
from ethers-ens.
This is hard to support in the CLI, but the tool run by ens makes this quite simple.
That said, keep in mind the danger of buying these domains; you will likely want to by all obvious pseudo-homoglyphs. For example, if you buy lächeln.eth
, you will also want to prolly buy lacheln.eth
.
Anyways, closing this now since it is managed in another repository now. Feel free to open a new ticket these. :)
from ethers-ens.
Related Issues (20)
- Move most safety checks into the library HOT 1
- Generic set-text KEY VALUE command HOT 1
- Testing HOT 1
- Feature Request: Should be able to reveal bids placed from MEW or the DAPP HOT 2
- Unsupported key-derivation function using Parity wallet HOT 3
- Support backspace in password entry HOT 1
- Error: replacement transaction underpriced HOT 12
- reveal-bid instruction not showing correct bid amounts HOT 3
- ignore overrides all commands placed later HOT 2
- unable to reveal bid after deadline HOT 2
- allow user to change the gas price HOT 3
- Import Bids HOT 14
- startAuctionsAndBid - Feature? HOT 3
- Gwei Price 99 - Auto Gwei? HOT 1
- Subnode Creation HOT 1
- Release ENS names HOT 4
- transactions not picked up when using --nonce HOT 1
- 3-6 character auction HOT 3
- EIP1577 support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ethers-ens.