GithubHelp home page GithubHelp logo

getTxMerkle arguments about bitcoin-proof HOT 3 CLOSED

ethers avatar ethers commented on June 3, 2024
getTxMerkle arguments

from bitcoin-proof.

Comments (3)

ethers avatar ethers commented on June 3, 2024

Thanks for the feedback. Agree there's some redundancy.
IIRC the proofObj returned by getProof previously didn't have the transactionHash (txHash), since the API before was getProof(transactions, transactionHash).

So getTxMerkle doesn't use the txHash in proofObj.
Now getTxMerkle(transactionHash, proofObj) is simpler than getTxMerkle(transactionHash, merkleSiblings, transactionIndex). So I think the redundancy is ok since it makes getTxMerkle clearer.

from bitcoin-proof.

fanatid avatar fanatid commented on June 3, 2024

Don't you mind if I shall create PR with changes? Also I would add semistandard as linter.

from bitcoin-proof.

ethers avatar ethers commented on June 3, 2024

Sure, we can discuss PR with your changes. semistandard looks good. Thanks

from bitcoin-proof.

Related Issues (1)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.