GithubHelp home page GithubHelp logo

Comments (5)

mrtazz avatar mrtazz commented on July 28, 2024

I'm not sure if we really need LOCK_NB here, so I'd say adding a conditional based on the OS makes the most sense at the moment.

from logster.

benburry avatar benburry commented on July 28, 2024

@jblaine did you eventually create a patch for this? How would you feel about submitting it as a pull request?

from logster.

jblaine avatar jblaine commented on July 28, 2024

No, I didn't, but I sure can.

from logster.

jblaine avatar jblaine commented on July 28, 2024

Yeah. Uh. Take the latter of those two: 3855c30

from logster.

sferencik avatar sferencik commented on July 28, 2024

For the record: as suggested in #91, I submitted a pull request (#92) that adds support for locking files on Windows. This is done using the portalocker module.

portalocker.unlock() also works on Unix, where it internally calls fcntl.flock(fd, fcntl.LOCK_UN). Note that there's no fcntl.LOCK_NB.

That's in line with @jblaine's suggestion to merely use fcntl.LOCK_UN.

from logster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.