GithubHelp home page GithubHelp logo

Comments (4)

Ukendio avatar Ukendio commented on May 18, 2024

What is the context to this? Why is it being deleted, is it rewire? Rewire should be utilising the loop:rescheduleSystem so this problem shouldn't be happening

from matter.

metrowaii avatar metrowaii commented on May 18, 2024

This was part of a test I was conducting with the new scheduler logic. Imagine the case where you delete a system that another system has a dependency on - when rewire replaces the system, the logic that schedules the systems is called again throwing an error which is what you see in the image. But the errors following the first one are being thrown because the loop is still running even though the scheduling logic failed. The solution here would be to stop the existing loop if an error is thrown by the scheduling. I should note that this is very low priority. I don't think anyone is deleting systems while testing.

from matter.

Ukendio avatar Ukendio commented on May 18, 2024

error is thrown by the scheduling

Yeah this makes sense to me, but I need to read some of the scheduling logic to understand its semantics to make a decision on what we want to do. It has changed quite a bit since last time I had a read half a year ago. Were these issues present before https://github.com/evaera/matter/pull/54 ?

from matter.

metrowaii avatar metrowaii commented on May 18, 2024

I never tested this behavior before my scheduler changes, but I'm fairly confident that this issue was present. The only difference would be the message of the first error that is thrown.

from matter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.