Comments (4)
What is the context to this? Why is it being deleted, is it rewire? Rewire should be utilising the loop:rescheduleSystem so this problem shouldn't be happening
from matter.
This was part of a test I was conducting with the new scheduler logic. Imagine the case where you delete a system that another system has a dependency on - when rewire replaces the system, the logic that schedules the systems is called again throwing an error which is what you see in the image. But the errors following the first one are being thrown because the loop is still running even though the scheduling logic failed. The solution here would be to stop the existing loop if an error is thrown by the scheduling. I should note that this is very low priority. I don't think anyone is deleting systems while testing.
from matter.
error is thrown by the scheduling
Yeah this makes sense to me, but I need to read some of the scheduling logic to understand its semantics to make a decision on what we want to do. It has changed quite a bit since last time I had a read half a year ago. Were these issues present before https://github.com/evaera/matter/pull/54
?
from matter.
I never tested this behavior before my scheduler changes, but I'm fairly confident that this issue was present. The only difference would be the message of the first error that is thrown.
from matter.
Related Issues (20)
- Allow components to be constructed with default values
- Expose Topo cleanup routine
- Use __iter [in addition to?] __call HOT 1
- Require casing does not match ModuleScript name casing
- <SystemTable>.after does not accept importing <SystemTable>.system HOT 2
- Detect and throw better error when using a ComponentInstance instead of a Component
- Debugger: Edit components in debugger view
- Debugger: Query UI Bug
- Put example game files in a single folder HOT 3
- Add QueryResult:toList()
- Reconciliation docs page uses old queryChanged signature HOT 1
- Toggle state window in debugger HOT 1
- Handle case where priority of a system is earlier than systems defined in after
- Systems with undefined dependencies cause crash
- Add support for Deferred Signal Behavior
- TestEZ is listed as a regular dependency HOT 1
- UseThrottle don't work HOT 2
- Latest release download button redirects to wrong release HOT 1
- Add additional error on improper component insertion
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from matter.