Named namespace and function import doesn't work. about esbuild

[tmikaeld]

I'm guessing this is the right way to use this:

import KJUR, { b64toBA, b64utob64 } from 'jsrsasign';

Feel free to close the issue if you don't want to handle both.

[evanw]

It's possible that this was fixed earlier. I'm guessing the fix was adding support for CommonJS default exports via __esModule in #17.

I'm going to close this since it looks like this is working fine now:

import KJUR from 'jsrsasign';
import { b64toBA, b64utob64 } from 'jsrsasign';
console.log(KJUR.crypto.DSA, b64toBA, b64utob64);

import { KJUR, b64toBA, b64utob64 } from 'jsrsasign';
console.log(KJUR.crypto.DSA, b64toBA, b64utob64);

import KJUR, { b64toBA, b64utob64 } from 'jsrsasign';
console.log(KJUR.crypto.DSA, b64toBA, b64utob64);

When bundled with esbuild using --bundle and then executed using node, all three of these output the same thing: [Function (anonymous)] [Function: b64toBA] [Function: b64utob64].

[gabrielalmeida]

I've run into a situation where re-exported namespaces are not bundled properly as named exports when using barrel files and export star syntax.

When doing this:

import {
  namedPropFromB,
  proto
} from "pkg";

I'd get the following on node runtime:
SyntaxError: The requested module 'pkg' does not provide an export named 'proto'

It will build and generate valid DTS about the exported proto NS.

---

Original pkg exports are as follows:

index.js

import A from './A'

export * from '../proto'
export * from './B'

export default A

Proto is generated by pbjs from protobufjs, not to confuse with pbjs also from @evanw:

yarn pbjs -t static-module -w commonjs -o ./Proto/index.js ./Proto/Proto.proto;
yarn pbts -o ./Proto/index.d.ts ./Proto/index.js;

...
// Exported root namespace
var $root = $protobuf.roots["default"] || ($protobuf.roots["default"] = {});

$root.proto = (function() {

    /**
     * Namespace proto.
     * @exports proto
     * @namespace
     */
    var proto = {};

     proto.Something = (function() {
       ...
    }

    return proto;
})();

module.exports = $root;

esbuild bundle:

...
Object.defineProperty(exports, "__esModule", { value: true });
const A_1 = __importDefault(require("./A"));
__exportStar(require("./B"), exports);
__exportStar(require("../Proto"), exports);
exports.default = A_1.default;

---

I'd expect proto to be accessible as a named export but it won't. The only way to use its types and runtime methods is:

import {
  namedPropFromB,
  // proto // typescript finds it but node will fail on runtime
} from "pkg";

import * as pkg from "pkg";

const sample = pkg.proto.Something.Method(value) as pkg.proto.Something.ISomething;

[evanw]

@gabrielalmeida You should file a new issue if you believe you have found a bug with esbuild. It would also be helpful to have a self-contained reproduction on https://esbuild.github.io/try/.

  // proto // typescript finds it but node will fail on runtime

Keep in mind that you need --platform=node when building for node. In this case esbuild generates annotations for node so node's syntactic CommonJS analyzer can find the re-exported export names: #2486.