GithubHelp home page GithubHelp logo

Output is incorrect when there is an import declaration with an import clause that has one type only import specifier about esbuild HOT 3 CLOSED

jordimarimon avatar jordimarimon commented on September 28, 2024
Output is incorrect when there is an import declaration with an import clause that has one type only import specifier

from esbuild.

Comments (3)

hyrious avatar hyrious commented on September 28, 2024 1

Is it correct to have an import declaration with an empty import clause?

Yes. It is different between importing a module or not importing it at all. The former means to keep any side effects in the dependency.

For example, if ./foo.js has code:

// foo.js
console.log('side effect')

As a consequence the user ideally should see the log at runtime. That's why the import statement is kept.

from esbuild.

hyrious avatar hyrious commented on September 28, 2024

This is because you have set verbatimModuleSyntax: true. esbuild is generating the effectively same code as TypeScript compiler itself: TypeScript Playground

from esbuild.

jordimarimon avatar jordimarimon commented on September 28, 2024

I wasn't aware of the fact that the TypeScript compiler also behaves like this. Thanks for pointing it out!

Having said that, is it correct to have an import declaration with an empty import clause?

What side effects could cause if esbuild dropped entirely the import declaration if only types are being imported?

I can understand that esbuild may want to output similar code as the TypeScript compiler, but right now I don't see why it's important to keep the import declaration.

Feel free to close it if this is the expected behavior.

Thanks for the answer!

from esbuild.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.