GithubHelp home page GithubHelp logo

Comments (2)

rrrship avatar rrrship commented on July 20, 2024

Actually I found out one issue with my tests. I will try to make a new test case.

from eventuate-tram-sagas.

rrrship avatar rrrship commented on July 20, 2024

Here is the updated version with the class which has the failing tests in my fork.

I looked around a little bit in the code and I noticed one difference between reactive and non-reactive, and it's in the ReactiveSagaManagerImpl.java file, line 182. There the data variable is passed to handleReply method, but it's coming from getSagaData(si) method call, while the data variable is also initialized separately on line 180. When I change line 182 to this, then these tests actually pass:
Mono<SagaActions<Data>> actions = Mono.from(getStateDefinition().handleReply(sagaType, sagaId, currentState, data, message));

I'm wondering though if there might be some reason for doing it like this or it's a bug, @cer

from eventuate-tram-sagas.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.