Comments (5)
Really I think this would require this to be converted into an NPM project to add grunt, eslint and/or other tools to check code style, thoughts?
from image-scrubber.
I'm trying to keep this project as light-weight and human readable as possible and don't want to convert to NPM, but I agree that the code needs to be tidied pretty extensively. I think it might need to happen when there is less critical work to do though!
from image-scrubber.
While I agree that the code could be modularized better, I also think that it's very valuable that the project is as simple as it is, where all you have to do is to copy the html, js and css files into a directory and it will just work.
Adding a compilation step increases the barrier to entry for people who want to use the program locally and completely offline and are tech savvy enough to copy some files and open them in a browser, but do not know the javascript build tool ecosystem.
from image-scrubber.
Added a possible fix for this in #32!
from image-scrubber.
Closing with the merge from #32
from image-scrubber.
Related Issues (20)
- Add a homescreen icon for iOS HOT 1
- Save Image doesn't work when added to homescreen HOT 5
- Brush size cursor not visible halfway thru slider HOT 5
- No zoom control
- Add hover states and larger hitboxes HOT 1
- face detection to speed up blur/paint process? HOT 9
- Input stops after cursor leaves canvas HOT 1
- Brush smoothing HOT 1
- Brush size preview
- Flip image HOT 2
- Extended phone support HOT 6
- Absolutely critical mobile issue re: security layer HOT 2
- Black brush hard to see on dark/black background HOT 2
- Rotating blurs image HOT 1
- interpolatePath check HOT 2
- Some mobile browsers creating (new, non-identifiable) exif data on export to jpeg
- Video support possibility? HOT 2
- Crop, scale. HOT 1
- Usability notes HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from image-scrubber.