Inconsistent conversion NSNumber/String about evreflection

[evermeer]

Comparing the types before setting the values is not so easy. The dictionary from the json string will contain NSString, NSNumber, arrays and dictionary values. The object itself will have Swift.String, Swift,Int, Swift.Int64, Swift.Double, various enums and other values. The types are almost always different.

Besides that the check should also not break the workarounds that are in WorkaroundsTests.swift.

I would rather turn it around and also set the value when you are trying to put a number into a string. That would mean I only have to add 1 exception when setting the value. You have a property that has the same name in the json. the chance is big you want that json value in your object anyway.

[evermeer]

I have added the exception where a NSNumber can be set to a string property in the latest release 2.4.6. I would like to know what your idea is regarding that workaround. What objections could you thing of for solving it this way.

As an alternative I could also skip setting the value in the 2 specific situations (string to number and number to string) But then what happens when you have a string and someone forgot to set the quotes around a number in the json. I think I still favorite setting the value over not setting the value.

[kukudas]

Your solution is ok. The only objection i see right now is that it can cause confusion why this is possible.

[evermeer]

Thanks, then I will leave the fix as it is now.