GithubHelp home page GithubHelp logo

Iterative solvers are broken about exapf.jl HOT 2 CLOSED

frapac avatar frapac commented on August 11, 2024
Iterative solvers are broken

from exapf.jl.

Comments (2)

michel2323 avatar michel2323 commented on August 11, 2024

The Jacobian Jx was structurally symmetric (adjacency matrix is symmetric) before our reordering. By reordering the columns, the matrix is not symmetric anymore and the diagonal entries are 0. This worsens the Jacobi preconditioner which works best with a block diagonal structure (which is symmetric and matrix should be as diagonal dominant as possible).

I added some canonical tests and they seem to confirm that the preconditioner is implement correctly. The preconditioner also still works with the new ordering, however as the solution is worse, the Newton-Raphson is not able to converge with high enough accuracy.

Moreover, I think at some point we should look into an even better reordering and get a linear solver person involved.

I assign this to @dmaldona for now, as I think the solution for now is to switch back to the old ordering. I have a pushed the branch dev/ordering , where you can switch between the old and new ordering by setting a global variable debug to true or false.

from exapf.jl.

frapac avatar frapac commented on August 11, 2024

Fixed by #40

from exapf.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.