Type Annotations about psij-python

[hategan]

making type annotations mandatory for contributors

I'd be inclined to do so. I've seen many cases in which type annotations would have avoided a lot of bug hunting.

[hategan]

I think it's detrimental to attempt global policies like this. If we try to make decisions that apply to many projects, it will create a strong incentive to ensure that the "right choice" is made, which can lead to endless discussions.

As far as I'm concerned, I will attempt to annotate the code that I produce. I don't want to go into a long debate about the pros and cons of strong typing or it's attempt to emulate it with mypy in Python, so I'll leave it at that.

[jameshcorbett]

Oh, OK. From some of the comments I thought maybe you (or others) were thinking of making type annotations mandatory for contributors.

Even just for this repo, I think it might be good to have a one-sentence policy, saying whether they are optional/recommended/required. I was planning on contributing, and seeing all of the type-annotated code, I probably would have assumed they were required.

[SteVwonder]

👍 I would support a recommendation/requirement for type-annotations.

[kylechard]

Seems like we agree here that we should require type-annotations.