Comments (6)
I wonder though if we might consider using jinja instead?
We want a cross-language solution.
from psij-python.
I can fork an updated version, tag, and we can use that until we either move to a different implementation, different engine, or the one currently on pypi gets fixed. Does that sound reasonable?
from psij-python.
If you want to take on the responsibility yourself, whatever you want to do to get things working is fine by me. I just want things to work, and I would love to get the readthedocs build to pass so our CI will actually turn green.
Our mustache options don't seem great to me at first glance, although they might turn out well upon testing. We could always just try out chevron or the new pystache and see how it goes, and whether the developers are responsive, and then decide if we want to use one of them.
I'm not convinced that we should really care that much about a cross-language solution. We're not using our templating libraries for anything very complicated so it's generally a pretty straightforward translation from one templating library to another (are the delimiters {%
or {{
or %%
?). My guess is that re-writing the templating stuff would be like 5% of the work of a new PSI/J language implementation.
But mustache is what we have now so we should try to make it work.
from psij-python.
I'm not convinced that we should really care that much about a cross-language solution. We're not using our templating libraries for anything very complicated so it's generally a pretty straightforward translation from one templating library to another
It's an unnecessary step for users on a system that needs customized templates to have to do so for every language implementation and test such copy separately. We may never really get to that point, but, if we do, I'd rather not be in that situation because of a temporary snag with a library. It may be useful to recognize that we cannot, in general, guarantee that any of our dependencies will always be nice and dandy.
from psij-python.
A recent version of pystache is now available and PR #100 switches to it.
from psij-python.
#100 was merged into main, so this should be fixed now.
from psij-python.
Related Issues (20)
- polling for jobs removed from the queue does not properly mark them as completed HOT 6
- Documentation: Example for how to load modules HOT 2
- Implement https://github.com/ExaWorks/job-api-spec/pull/168 HOT 1
- Implement https://github.com/ExaWorks/job-api-spec/pull/172
- Incorrect job duration formatting for SLURM HOT 2
- Proposal: Allow JSON-serializable format for `duration` in `JobAttributes` HOT 7
- `main` branch breaks `custom_attributes` (at least for Slurm) HOT 3
- Some words are cut off on PSI/J Python Webpage HOT 1
- Next steps for a new release? HOT 4
- The `environment` kwarg in `JobSpec` gets the wrong number of quotation marks if there are spaces HOT 4
- Not able to get ResourceSpecV1 working with PBS HOT 4
- PBS walltime hour is being formatted as a float causing job submission failure
- Account vs. project HOT 2
- Dependency on typeguard 2.12 conflicts with other packages. HOT 3
- Leftover of `distutils.` in 0.9.5 HOT 1
- Dependency `filelock` move to requirements-tests HOT 1
- `requirements.txt` missing from PyPI source code HOT 4
- Deprecation warning for "project_name" is always triggered HOT 2
- CANCELED status after cancel() HOT 1
- Feature request: support for psutil 6.0 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from psij-python.