GithubHelp home page GithubHelp logo

Comments (3)

excid3 avatar excid3 commented on July 17, 2024

The real issue here is that store :metadata is not being ignored. https://github.com/rails/rails/blob/main/activestorage/app/models/active_storage/blob.rb#L42

We should make sure that Madmin resouce generator ignores metadata and generates attributes for each of the store accessors. I thought that was working.

That said, #112 does fix it if attribute :metadata was left in or added so that's definitely good to have.

from madmin.

jacobdaddario avatar jacobdaddario commented on July 17, 2024

@jitingcn Was this an issue with the freshly generated app or with the Madmin dummy app? The stored_attributes method call works fine on ActiveStorage::Blob, and so store value should be ignored. Additionally, its accessors should be included as attributes when generating.

Maybe this is a case where the dummy app still had attribute :metadata left in its ActiveStorage::Blob directory? I've noticed that the dummy app's resources tend to get out of sync with changes to the library sometimes.

from madmin.

jitingcn avatar jitingcn commented on July 17, 2024

Maybe this is a case where the dummy app still had attribute :metadata left in its ActiveStorage::Blob directory? I've noticed that the dummy app's resources tend to get out of sync with changes to the library sometimes.

Yeah, my app haven't removed attribute :metadata, since stored_attributes support just add recently and I won't regenerate resource file all the time. But this is just an small issue :)

from madmin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.