GithubHelp home page GithubHelp logo

Comments (7)

olleolleolle avatar olleolleolle commented on June 2, 2024

The UPGRADING guide in Faraday has a mention, now, of this - the recommendation is "use a regular require, instead of the deferred (and also, hehe, now-removed) "dependency" method.

Hope this helps!

from faraday-excon.

iMacTia avatar iMacTia commented on June 2, 2024

Mmmmh although the dependency method was removed in Faraday 2.0 🤔
faraday-excon has a gemspec dependency to faraday ~> 1.0, so how did your bundle load it together with Faraday 2.0?

from faraday-excon.

prettycoder avatar prettycoder commented on June 2, 2024

@iMacTia
the gemspec has add_development_dependency for faraday ~> 1.0, so that version is not loaded by default 🥺
@olleolleolle
It explains, but that line of code with dependency is in this repo. Shall I create a PR?

from faraday-excon.

prettycoder avatar prettycoder commented on June 2, 2024

no PR needed, it is already gone in main. removed here 75a3383
Could you release a new gem version?

from faraday-excon.

olleolleolle avatar olleolleolle commented on June 2, 2024

Right, for completeness, the workaround is to use this gem from the GitHub repository: in your project's Gemfile, include this gem like so

 gem "faraday-excon", github: "lostisland/faraday-excon"

A new release is needed to make the need for the workaround go away.

from faraday-excon.

olleolleolle avatar olleolleolle commented on June 2, 2024

@prettycoder The new version has been released as 2.0.0. Thanks for reminding!

from faraday-excon.

prettycoder avatar prettycoder commented on June 2, 2024

thanks for the quick turnaround :)

from faraday-excon.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.