GithubHelp home page GithubHelp logo

Comments (4)

 avatar commented on August 23, 2024

I agree and have found this confusing as I start contributing to the v3 effort again.
I would like to know if the markdown I introduce for Rust documents has issues. Instead I see that multiple other tracks have linting issues and it distracts me focusing on what the Rust track needs.

from concepts.

SaschaMann avatar SaschaMann commented on August 23, 2024

In general I think global checks are to be preferred unless they take too long. If master is green, a failure must've been introduced in the PR anyway. It's more robust. Some checks that only ran on changed files before ended up failing on master despite being green in the PR.

A mandatory check is strictly better than an optional one: it requires fewer judgment calls.

I agree. Those checks were expected to fail as a temporary annoyance until all tracks created those files (that plan didn't work so well because ignoring the checks lead to more missing files over time 🤷), at which point they were meant to become mandatory.

from concepts.

 avatar commented on August 23, 2024

My practical need has been addressed. I had not realized the master branch had fixes. I do not have a strong opinion here so will defer to @SaschaMann since he maintains the CI.

from concepts.

iHiD avatar iHiD commented on August 23, 2024

Closing this as this repo is now closing.

from concepts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.