Comments (7)
(cc @exercism/crystal @ErikSchierboom)
from crystal.
I would agree that it does.
The "black and X" test is track-specific. I proposed in exercism/problem-specifications#1605 two months ago that we add this as a canonical test case to clarify. The problem description mentions that there will always be two digits, but the canonical tests use numbers and not strings, and only 1 of 12 implementing tracks always return two digits.
This PR came after I recently refactored this exercise on the Haskell track: exercism/haskell#865. I suggest you submit a PR to the Crystal track in which you make sense of the exercise in a way that is appropriate for Crystal.
from crystal.
This PR came after I recently refactored this exercise on the Haskell track: exercism/haskell#865. I suggest you submit a PR to the Crystal track in which you make sense of the exercise in a way that is appropriate for Crystal.
This would also be my suggestion.
from crystal.
Moved to the Crystal track.
from crystal.
Howdy!
I'd definitely appreciate a PR to the generator for this exercise! If not, I can do it as well. Thanks for bringing this issue up.
from crystal.
@konung - I believe this is resolved, can you confirm?
from crystal.
Yes I believe so.
from crystal.
Related Issues (20)
- consider making each exercise's test generator its own binary instead of all in one generator binary
- Rewrite the generator
- Add docs for the new generator
- Impliment the new generator
- Add tests for the new generator
- Add support for additonal_config.json for the generator
- Update the ci for the new generator
- Make a generator in liquid
- Seperate Ci tests
- [Concept]: Add Basic
- [Concepts]: Add Bools
- [Concepts]: Add numbers
- [Concepts]: Add number types
- [Concepts]: Add classes
- [Concepts]: Add strings
- [Concepts]: Add string-methods
- [Concepts]: Add conditionals
- [Concepts]: Add Ternary Operator
- [Concepts]: Add while loops
- [Templates]: Use standard-libary methods HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crystal.