Comments (4)
@kotp Thank you! I'll close this issue then. The many styles of programming will be seen when users solve the problems (I'll try to slowly solve them too) :-)
from crystal.
TL;DR; The code in the example.cr
is "proof of concept" rather than idiomatic, but there is no reason it couldn't be idiomatic code. It is not "front facing", not presented to the users of Exercism, but of course is available for those that are curious.
Kytrina has mentioned that the example code in the repository has been "Proof Of Concept", and to proof the tests that are presented to the users of Exercism.
She has also mentioned that it may be beneficial to be idiomatic, which is definitely possible over time.
It is not code that is gathered by the client, so it is not "front facing" code, though, of course, it is available for anyone to view if/when they come to the repository. I don't believe there is anything currently directing them to the example code at all, in the flow of the client and process of participating on the 'user' level.
It has been discussed that the tests should be as idiomatic as possible, as that is forward facing.
from crystal.
@kotp , I would agree that the examples should probably be the best they can be (like a gold standard) but... that will happen over time.
@asterite , your solution was awesome to see! Thanks for that!
from crystal.
@asterite I originally wrote this as a single method with if elsif
but then changed it to be more dry. I had gotten feedback on previous solutions that they should have a lot more methods "like the ruby one", so I also broke it up into more methods. I agree that it probably wasn't necessary though.
One advantage to your solution is that it returns as soon as it's false and stops evaluating. :)
from crystal.
Related Issues (20)
- Confusing sentence about method return values HOT 1
- Inconsistent class method names HOT 2
- Blackjack Spec
- [BlackJack]: Inconsistent class methods name HOT 2
- URL to ICR is out of date HOT 7
- Add practices to practice exercises HOT 1
- Crystal Analyzer generated feedback is not visible HOT 2
- [Luhn] Unrelated Time#leap_year? ban in Luhn exercise
- [Meltdown Mitigation] Rename `is_criticality_balanced?` to `criticality_balanced?`
- Building a training set of tags for crystal HOT 23
- Deprecate scale-generator?
- Some possible language/typo corrections to the Library of Luton exercise README HOT 2
- Minor language correction in the Instructions to the Bellebrook Basket League exercise HOT 2
- [New Practice Exercise]: Parallel letter frequency HOT 2
- [New Practice Exercise]: Zebra Puzzle HOT 5
- 🤖 Sync error for commit 8cb214 HOT 8
- On exercise "navigation-computer" - tests are passing even when last task is not implemented HOT 1
- [New Practice Exercise]: Dnd Character HOT 3
- [New Practice Exercise]: Food Chain
- [Create Approach]: List Ops
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crystal.