Comments (8)
This is some great troubleshooting, @Stargator. Thank you.
from dart.
The markdown parsing code we're using has changed for v2, so whatever turns up here will need to be applied there too.
from dart.
@iHiD I actually do not see the Tests page for Java in v2. Are you saying there are two different parsing logic for v2 and v1?
Since v2 of Java isn't using the TESTS.md page it's hard to tell if v2 handles v1 the same from where I am.
from dart.
I'm pretty sure that if we fix the markdown for v1 it will also be fixed for v2 (but yes, v2 does markdown parsing differently—better—than v1).
from dart.
@iHiD @kytrinyx Should this issue be closed and opened in a different repo? Since it seems to concern the markdown parsing, I want to check if this is okay.
from dart.
Also I can confirm, that v2 suffers from the same problem, I posted the dart test-documentation straight into a comment on my own exercises ;)
from dart.
@Stargator Yeah, would you mind posting reproduction steps in https://github.com/exercism/v2-feedback/issues ? (A markdown comment that exhibits the same behavior as the dart test docs would probably be our best bet here)
from dart.
@kytrinyx I will post the same thing there as well and close this issue.
My findings:
Redcarpet with code formatting as seen in the image in the initial post does not convert to the expected html format. The code formatting breaks the numbering for lists.
I created a jekyll project to test our Markdown library redcarpet. You can find it a project for redcarpet here and a jekyll project using kramdown here.
I will be making the same post in the redcarpet project as well by COB today.
The problem remains when using quotes with redcarpet:
Or not using any formatting at all:
Comparatively, Kramdown does not have this issue:
Though I do not know the full scope of our use of redcarpet, so I do not know if there is anything specific that redcarpet does that we depend on.
As stated, this will be posted in the aformentioned repo by @kytrinyx as well as the redcarpet repo.
from dart.
Related Issues (20)
- Add or Update existing GitHub Action to check for bad links HOT 7
- Should the template for "Isbn Verifier" have a class? HOT 1
- Replace all dartlang.org links with dart.dev
- Does ABOUT.md Need a Mention of Flutter? HOT 3
- Configure Online Editor Task Complete
- Make Test Driven Development More Prominent in Exercise Instructions HOT 4
- Dart tests are default on skip:true HOT 1
- Structure of test files for generated exercises? HOT 12
- How to best run tests locally on just the exercise being worked on? HOT 5
- Question about initialization in test suites HOT 6
- dart fix is removing import in test suite HOT 5
- [CI] Re-enable link checker HOT 11
- Drop use of types for variables when not necessary HOT 1
- Armstrong Numbers: do we want to add BigInt? HOT 3
- Syntax question -- lists, and types and lists of lists HOT 2
- Why is skip true for all the tests? HOT 2
- Gigasecond method name could be changed HOT 2
- Wide right section cause layout issues HOT 2
- Deprecate `beer song`? HOT 1
- I noticed all the testcases except first one are marked for skip. Any reasons ? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dart.