Comments (10)
I can confirm, Erik's solution does seem to pass the tests. It's great solution actually :)
Marking community solutions as outdated and failed is a site-wide process (and I don't know how it works), so there is not much the Elm track can do about that.
@ErikSchierboom maybe this issue should be transferred to exercism/exercism?
from elm.
Well, they are failing because each exercise is linked against a specific exercise commit. To get them passing, students need to update their exercise to the latest version.
from elm.
@ErikSchierboom so Outdated
also implies Failed
right? Is there a way to distinguish outdated solutions that were passing and outdated solutions that were failing?
from elm.
@mpizenberg Nope, they're not the same. Outdated means that there is a newer version of the exercise available, but it doesn't mean that is must be failing. The newer version could just have updated instructions.
from elm.
Is there a way to distinguish outdated solutions that were passing and outdated solutions that were failing?
The community solutions page has three checkboxes with which you can filter the solutions, including outdated and passing the tests (not the reverse).
from elm.
@mpizenberg Nope, they're not the same. Outdated means that there is a newer version of the exercise available, but it doesn't mean that is must be failing. The newer version could just have updated instructions.
So it's not only the exercise commit that is verified but also the things that changed? If the tests file changed it's also marked Failed
but if it's only docs, it's only marked Outdated
is that it?
Or we might not be talking about the same thing when saying "exercise commit". Are you referring to the "last commit in which the exercise tests were changed", which is different than the "latest track commit when the exercise was started by the student"?
from elm.
In any case, it seems that's a question better discussed on the main exercism repo or in slack so I'm closing this issue. Thanks again for the participants.
from elm.
@mpizenberg are you going to open the issue in the main exercism repo or should I? The slack you talk about is a public slack or an internal one?
from elm.
@552020 I mean the official public slack. But you might be right, actually I don't remember and it's possible it's only for mentors and maintainers. Let me ask there, and answer you when that's clear to me
from elm.
@552020 So I figured out what is happening by talking to my rubber duck. Erik's solution was submitted at a time where the exercise structure was different. Basically he had a Exercise.elm
file and now we have src/Exercise.elm
files. When website testing was introduced with v3, the tests ran with the template src/Exercise.elm
file and so the tests failed with the todo still being in the template file.
This error will happen for all solutions submitted previous to november 2019 when I updated the track structure for elm 0.19.1
from elm.
Related Issues (20)
- bettys-bike-shop tests do not actually verify type signature HOT 1
- Wrong type mentioned in the description of step 4 of the learning exercise Secure Treasure Chest HOT 1
- Wrong instruction about makeTreasureChest in part 1 of the description in the learning exercise Treasure factory HOT 5
- Small correction in the introduction in the learning exercise Magician in Training HOT 1
- Update strain test HOT 1
- Unsynced docs and metadata HOT 3
- Concept Exercise for Strings HOT 3
- Implement new pop-count HOT 3
- Building a training set of tags for elm HOT 29
- Fill all exercises with accurate "practices" and "prerequisites" concepts
- Parse tags from student solutions HOT 9
- Exercise Binary Search Tree Missing Instructions and Hints
- Concept - Web applications part 1
- Port `reverse-string`? HOT 1
- Add approaches for leap
- Add `protein-translation` and `rotational-cipher` exercises HOT 2
- Add approaches for Allergies practice exercise
- Add markdown linter to CI
- Add test cases to excercise Gotta Snatch'Em All HOT 1
- Concept: recursion
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from elm.