Comments (10)
Gradually submitting PRs is totally fine! If there are some examples that don't work well in Japanese or that show an NLP concept that's difficult to get across with Japanese text, we could also leave them in English.
You probably want to base the PR off #69, which updates the course to spaCy v2.3 and the new models. It's not ready yet, since some of the examples in Spanish need adjustments to make them work with the new models.
from spacy-course.
@tamuhey Sorry for late reply. I'd like to replace the Japanese examples with the results of the latest Japanese model.
@ines Could you tell me an appropriate base branch or PR which I'd replace Japanese examples?
from spacy-course.
@hiroshi-matsuda-rit I think the master is appropriate. Is this alright, @ines ?
from spacy-course.
Yes, that would be amazing! ๐ Some of the exercises will probably need adjustments to make them work with Japanese text while getting the same objectives across, like different combinations of tokens, match patterns, example texts, plus examples that the model gets right reliably etc. That's also how we did it for German and Spanish. Some of the text examples ended up very different from the originals.
I'm also happy to answer any questions or help (to the best of my abilities ๐)
from spacy-course.
@ines thanks!
When should we make Pull Requests?
- After replacing everything with the Japanese model
- Gradually submit PRs when some slides are updated
I'm more than happy with the latter, as I can't take off a large amount of time.
from spacy-course.
@tamuhey Thanks. I'd like to start editing chaters/ja/
and excersizes/ja/*
on master branch. Which kind of IDE are you using for the spacy-course
project?
from spacy-course.
@tamuhey It seems we need to translate the example files below. Actually, I do not have enough time for that translation works. Sorry.
excersizes/ja/
- backquotes.json
- capitals.json
- countries.json
- country_text.txt
- gadgets.json
- iphone.json
- tweets.json
from spacy-course.
@hiroshi-matsuda-rit
I'm using VSCode, but why?
It seems we need to translate the example files below. Actually, I do not have enough time for that translation works. Sorry.
I also don't have enough time to translate all of the files at once, but I can gradually commit.
from spacy-course.
I'm using VSCode, but why?
Thank you. I'd like to use same environment.
May I start discussing about how to share the translation tasks?
I've forked spacy-course on my account. https://github.com/hiroshi-matsuda-rit/spacy-course
Shall we use it for this issue?
In addition to the files which I listed above, we should add some Japanese specific files like exercises/zh/exc_01_02_04.py
.
Could you list the required files? @tamuhey
from spacy-course.
Thank you. I'd like to use same environment.
Thanks!
Shall we use it for this issue?
All right!
Could you list the required files
OK!
from spacy-course.
Related Issues (20)
- Repeated failed connections trying to access course HOT 1
- Diagram for the Span object
- Building a training loop - update example from spacy101 v2.x tutorial
- Wrong word segmentation in chinese course HOT 1
- Advanced Spacy Course: Bowie is a word HOT 4
- Turkish Translation would be great idea ! HOT 4
- error in builidng docker HOT 1
- Chapter 2 ยง 4 prose disagrees with code HOT 1
- Chapter 1 q11 Matcher matches all text. HOT 2
- amendments suggestion HOT 2
- Trouble setting up a working JS environment for the course HOT 6
- Why does chapter 2 section 7 solution use iteration instead of matching? HOT 2
- French translation? HOT 2
- Chapter 1 Lesson 9 requires student to name the entity iterator variable 'ent' -- unnecessarily HOT 1
- Phrase Matcher fails on custom tokens HOT 1
- Issue with matcher in Excercise 1.12.2 HOT 1
- Missing implementation to output matches from the matcher at chapter1_03_rule-based-matching.md
- JS code insdie <script> tags is not exectued
- Trouble running code for Exercise 5 in Chapter 4 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spacy-course.