GithubHelp home page GithubHelp logo

Comments (10)

ines avatar ines commented on May 12, 2024 2

Gradually submitting PRs is totally fine! If there are some examples that don't work well in Japanese or that show an NLP concept that's difficult to get across with Japanese text, we could also leave them in English.

You probably want to base the PR off #69, which updates the course to spaCy v2.3 and the new models. It's not ready yet, since some of the examples in Spanish need adjustments to make them work with the new models.

from spacy-course.

hiroshi-matsuda-rit avatar hiroshi-matsuda-rit commented on May 12, 2024 1

@tamuhey Sorry for late reply. I'd like to replace the Japanese examples with the results of the latest Japanese model.
@ines Could you tell me an appropriate base branch or PR which I'd replace Japanese examples?

from spacy-course.

tamuhey avatar tamuhey commented on May 12, 2024 1

@hiroshi-matsuda-rit I think the master is appropriate. Is this alright, @ines ?

from spacy-course.

ines avatar ines commented on May 12, 2024

Yes, that would be amazing! ๐Ÿ™ Some of the exercises will probably need adjustments to make them work with Japanese text while getting the same objectives across, like different combinations of tokens, match patterns, example texts, plus examples that the model gets right reliably etc. That's also how we did it for German and Spanish. Some of the text examples ended up very different from the originals.

I'm also happy to answer any questions or help (to the best of my abilities ๐Ÿ˜‰)

from spacy-course.

tamuhey avatar tamuhey commented on May 12, 2024

@ines thanks!
When should we make Pull Requests?

  1. After replacing everything with the Japanese model
  2. Gradually submit PRs when some slides are updated

I'm more than happy with the latter, as I can't take off a large amount of time.

from spacy-course.

hiroshi-matsuda-rit avatar hiroshi-matsuda-rit commented on May 12, 2024

@tamuhey Thanks. I'd like to start editing chaters/ja/ and excersizes/ja/* on master branch. Which kind of IDE are you using for the spacy-course project?

from spacy-course.

hiroshi-matsuda-rit avatar hiroshi-matsuda-rit commented on May 12, 2024

@tamuhey It seems we need to translate the example files below. Actually, I do not have enough time for that translation works. Sorry.

excersizes/ja/

  • backquotes.json
  • capitals.json
  • countries.json
  • country_text.txt
  • gadgets.json
  • iphone.json
  • tweets.json

from spacy-course.

tamuhey avatar tamuhey commented on May 12, 2024

@hiroshi-matsuda-rit
I'm using VSCode, but why?

It seems we need to translate the example files below. Actually, I do not have enough time for that translation works. Sorry.

I also don't have enough time to translate all of the files at once, but I can gradually commit.

from spacy-course.

hiroshi-matsuda-rit avatar hiroshi-matsuda-rit commented on May 12, 2024

I'm using VSCode, but why?

Thank you. I'd like to use same environment.

May I start discussing about how to share the translation tasks?
I've forked spacy-course on my account. https://github.com/hiroshi-matsuda-rit/spacy-course
Shall we use it for this issue?

In addition to the files which I listed above, we should add some Japanese specific files like exercises/zh/exc_01_02_04.py.
Could you list the required files? @tamuhey

from spacy-course.

tamuhey avatar tamuhey commented on May 12, 2024

Thank you. I'd like to use same environment.

Thanks!

Shall we use it for this issue?

All right!

Could you list the required files

OK!

from spacy-course.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.