GithubHelp home page GithubHelp logo

Comments (2)

dougwilson avatar dougwilson commented on May 6, 2024

The premise of the res.end and res.write to noop is flawed; it is 100% unnecessary. Because there was no investigation done in the original connect issue and no test proving it was necessary, it's hard to know, but I can only assume that those people were double-calling res.end() in their code, and of course since they were using compress() they saw it there; I bet if they removed compress() middleware, the error would have just triggered within http lib.

from compression.

dougwilson avatar dougwilson commented on May 6, 2024

So just to comment, I added a test that tests the functionality, then I tried to remove the patch keeping the test, and apparently on node 0.10+ calling res.write/res.end after the socket is ignored, but it throws on node 0.8, at least in my limited testing. Something to keep a note of. Right now the removal is just sitting in it's own branch for who-knows-when.

from compression.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.