GithubHelp home page GithubHelp logo

Comments (5)

krzysdz avatar krzysdz commented on April 27, 2024 1

I've opened a PR to fix it: DefinitelyTyped/DefinitelyTyped#68381

from express.

krzysdz avatar krzysdz commented on April 27, 2024 1

New version of @types/express-serve-static-core (4.17.43) was released with the documentation fix.

from express.

krzysdz avatar krzysdz commented on April 27, 2024

May I know which documentation are you referring to? The official documentation says:

The method returns the best match, or if none of the specified content types is acceptable, returns false ...

However, Express does not contain TypeScript definition files. The @types/express package is maintained by the DefinitelyTyped project, but the declaration of Request.accepts() there does not contain undefined as the return type in any overload.

from express.

Bunpasi avatar Bunpasi commented on April 27, 2024

express-serve-static-core/index.d.ts line 398.

from express.

Bunpasi avatar Bunpasi commented on April 27, 2024

Great! I heard you guys had some issues with contributions lately. I know this wasn't the most important thing, but I hope it will be helpful to someone.

from express.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.