Comments (17)
Meh I would just wait for proxies. This isn't really intuitive
from session.
Citating the example in README.md, you can add user-specific properties in this way
var sess = req.session;
if (sess.views) {
sess.views++;
} else {
sess.views = 1;
}
you can even store nested objects
from session.
@MichaelCereda This a feature proposal, not a question. ;)
from session.
Yes, I know that, but I'm guessing why it should be necessary?
you can already interact with session using getter/setter.
from session.
@MichaelCereda to know if the session was modified to write it back to the store.
from session.
ok so you need to fire an event when session "data" is changed...isn't it?
from session.
In order to implement this, we would probably need to have it on a different property of req
in order to not change the way it works currently. If someone wants to do something like this they may be better off looking into another library.
BUT, if it were a configuration option like asStore: true
and completely change the behaviour of the req.session
object, then it would be okay and non-breaking. Then again all that extra code for event firing and storing might increase the code-base by more than twice LoC, so we might as well have a different version that behaves like that.
from session.
@zombiehippie this would just be a major version bump, i.e. breaking. Also, there is no event firing here, it's just keeping a dirty flag.
from session.
this would just be a major version bump, i.e. breaking
@dougwilson I think you are right.
from session.
Yes, a major release will be a good thing and allows to implement other breaking feature requests.
from session.
I had already assigned this to a 2.0.0 milestone. :)
from session.
i don't think this is worth it unless you allow atomic updates on each .get()
. here's how i think sessions are supposed to look like: https://github.com/aheckmann/koa-mongodb-session
from session.
Thank you for the example, it should help us understand your suggestions.
On Jun 17, 2014 3:01 AM, "Jonathan Ong" [email protected] wrote:
i don't think this is worth it unless you allow atomic updates on each
.get(). here's what i think is how sessions are supposed to look like:
https://github.com/aheckmann/koa-mongodb-session—
Reply to this email directly or view it on GitHub
#46 (comment).
from session.
Is this still being pursued for 2.0.0? I also don't see a 2.0.0 branch, but there is a milestone. Any timeline?
from session.
No real idea, sorry. :/
from session.
Proxies are in Node v6, so this should actually be possible now.
from session.
I'd love to play with this. Or push a branch that does something interesting and make a PR and discuss it.
from session.
Related Issues (20)
- When Run frontend and backend in diff domain it not working HOT 2
- Undefined session object with apollo v4 express and express-session HOT 1
- Regenerated session is re-saved even if not modified since save HOT 1
- Allow for sessions to be shared between subdomains. HOT 1
- Invalid argument type express-session "1.17.3" and redis "4.6.7", HOT 1
- Request session destroy does not always resolve before returning HOT 1
- TypeError: Cannot read properties of undefined (reading 'reload') HOT 4
- [FEATURE REQUEST] Session Async Methods
- `SESSION.DESTROY()` DOES NOT DELETE SESSION. HOT 7
- A `destroy`ed session is still `touch`ed HOT 1
- cookie options won't get set HOT 13
- [Feature Request] Support of phasing out third-party cookies HOT 16
- req.sessionStore.all with typescript bug? HOT 7
- Don't `Set-Cookie` for static/public files? HOT 2
- Issue HOT 1
- Can't set partitioned cookie even though I updated all of the package HOT 6
- 'sha1' hash algorithm used at index.js is unsafe HOT 3
- Any good ways to refresh database data with a session? HOT 4
- Get session object from `req.session` outside of request context HOT 3
- express session is failing because session is undefined HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from session.