GithubHelp home page GithubHelp logo

Comments (3)

G4Vi avatar G4Vi commented on May 20, 2024 1

That sounds good. Let's some to some consensus with the team on naming of ExtismHandle before we proceed.

from extism.

zshipko avatar zshipko commented on May 20, 2024

I'm not opposed to reverting that change, we should just make sure to add a note somewhere that it should only be called on ExtismHandle values.

from extism.

zshipko avatar zshipko commented on May 20, 2024

We discussed making this change today, but when I was in the process of testing things out I realized there are some places where we make the assumption that non-handle offsets will return 0 for extism_length, such as https://github.com/extism/rust-pdk/blob/44370c59677037f71d4911ecd65de0af7e0e3de0/src/memory.rs#L42

This is only really an issue when taking input into a host function, where it's not clear if the offset was created using extism_alloc or not. I think it's best to keep the slightly more complex extism_length implementation for now. I will give this a little more thought this week.

from extism.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.