Comments (4)
Deflect does not properly declare Qt5Quick as a dependency; it misses
set(DEFLECT_DEPENDENT_LIBRARIES Qt5Quick)
somewhere before include(CommonPackageConfig) to resolved the Qt5::Quick target.
from cmake.
This indeed fixes the problem, thanks a lot. Strange that you need such a complex setup to observe the problem. One important detail is to use the package name (Qt5Quick) instead of the target name (Qt5::Quick) like in set(DEFLECTQT_LINK_LIBRARIES PUBLIC).
from cmake.
Maybe there's a spot to document this better. If a target is 'leaking', the corresponding find_dependency(...) call in the ProjectConfig.cmake has to be added via PROJECT_DEPENDENT_LIBRARIES so that CMake finds the target. Not needed in a super/subproject setup.
from cmake.
Something like this, yes, maybe in the readme.md so that people don't miss it.
We could also find a more precise name for the variable. It is not really LIBRARIES or target but its corresponding package name for find_package.
from cmake.
Related Issues (20)
- PROJECT_DESCRIPTION should not include ":" character
- COMMON_USE_CXX03 doesn't set -std flag HOT 6
- GitTargets.cmake has error on OSX HOT 1
- Move Doxygit.cmake to BBPDocumentation
- Remove per-system defines.h file generation HOT 2
- -WError abuse HOT 7
- Problems with pkg_check_modules output variable casing HOT 1
- Dependent libraries rebuilt HOT 1
- ninja rebase clones CMake/common for all subprojects
- "make prj-doxygen" invokes a "make install" HOT 2
- Cuda support HOT 8
- FindPackage not found persists HOT 1
- FindPackage not found persists [Reopen] HOT 5
- Extra targets HOT 1
- Subproject git modules not cloned recursively
- Please allow override of COMMON_DOC_DIR
- Mini-bug CommonGraph.cmake - change add CURR_DIR
- GitHooks does not handle running in submodules
- Do not override the default installation path to `/usr`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cmake.