GithubHelp home page GithubHelp logo

Comments (10)

Lej77 avatar Lej77 commented on July 24, 2024 1

You could probably simplify the Colour::intense method to Style { foreground: Some(self), .. Style::default() }.intense() to re use code.

from color-eyre.

yaahc avatar yaahc commented on July 24, 2024 1

Since there has been no movement on this upstream I'm fixing this issue locally in color-spantrace and color-eyre. I'll get out a new release with the fixed coloring shortly.

from color-eyre.

Lej77 avatar Lej77 commented on July 24, 2024 1

I tested the new version and it looks a lot better now, thanks!

from color-eyre.

yaahc avatar yaahc commented on July 24, 2024

I think it might make sense to try to get this fixed in ansi_term. Let's try opening an issue upstream, it ends up taking too long to get it merged / released up stream we can temporarily fix it here and in color-spantrace but I'd prefer to not duplicate code across crates if possible.

I'm gonna go open the issue rn

from color-eyre.

Lej77 avatar Lej77 commented on July 24, 2024

That sounds like a good idea! Don't know how robust this code is though, but if it has issues then they should probably be able to offer feedback!

from color-eyre.

yaahc avatar yaahc commented on July 24, 2024

Here we go ogham/rust-ansi-term#67

from color-eyre.

Lej77 avatar Lej77 commented on July 24, 2024

Seems good! What about fixed colors that are affected (the Fixed(color) if color < 8 => Fixed(color + 8), match arm in my example code)?

from color-eyre.

yaahc avatar yaahc commented on July 24, 2024

oo, good catch

from color-eyre.

Lej77 avatar Lej77 commented on July 24, 2024

Okay, that seems reasonable! Will be nice to get some better colors for my error messages.

from color-eyre.

yaahc avatar yaahc commented on July 24, 2024

should be good, try out 0.3.4 and lmk how it goes

from color-eyre.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.