GithubHelp home page GithubHelp logo

Comments (6)

yaahc avatar yaahc commented on July 24, 2024 1

Sounds like a great idea :D

Some Suggestions:

  • Instead of exposing a method to convert into the Box<dyn Fn...> implement the Into trait
  • remove the install_panic_hook fn and add an install fn to both EyreHook and PanicHook that calls the relevant `set_hook(self.into());
  • remove installed_printer() entirely and copy the appropriate filters needed by Eyre when printing backtraces into the eyre hook

from color-eyre.

yaahc avatar yaahc commented on July 24, 2024 1

heh, yea for the most part. I think I'm going to still add an into_panic_hook and into_eyre_hook because when you want to wrap the color-eyre hooks the into fn needs type annotations and getting them right is super cumbersome. Just missing a Send bound will break things for example. Overall though I'm pretty excited about this change.

from color-eyre.

yaahc avatar yaahc commented on July 24, 2024 1

closed by #67

from color-eyre.

kellpossible avatar kellpossible commented on July 24, 2024

The same goal could perhaps be achieved with a simple change to make print_panic_info() public.

Edit: no actually it's more complicated than that!

from color-eyre.

kellpossible avatar kellpossible commented on July 24, 2024

Thanks, those seem like great suggestions! 👍

from color-eyre.

kellpossible avatar kellpossible commented on July 24, 2024

@yaahc I'm guessing you've already implemented them in the commits you pushed yesterday?

from color-eyre.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.