Feature: Authorise with bearer token instead of basic auth about webdav-client-python-3

[ezhov-evgeny]

@danielloader I think it is possible I'll investigate it

[danielloader]

Lines 138 in client.py
Should really have checked!

`webdav_login`: (optional) login name for WebDAV server can be empty in case using of token auth.
`webdav_password`: (optional) password for WebDAV server can be empty in case using of token auth.
`webdav_token': (optional) token for WebDAV server can be empty in case using of login/password auth.

further investigation, Line 179 on client.py:

    if self.webdav.token:
        webdav_token = "Authorization: OAuth {token}".format(token=self.webdav.token)
        headers.append(webdav_token)
    return dict([map(lambda s: s.strip(), i.split(':', 1)) for i in headers])

This is giving a OAuth value not Bearer, and failing for me.

Relevant RFC https://tools.ietf.org/html/rfc6750#section-2.1

This barebones example (redacted creds) works for me:

import requests

url = f"{hostname}/on/demandware.servlet/webdav/Sites/Impex/src/"

headers = {
  'Content-Type': 'application/x-www-form-urlencoded',
  'Authorization': f'Bearer {bearer_token}'
}

response = requests.request("PROPFIND", url, headers=headers)

print(response.text.encode('utf8'))

[danielloader]

Put the request through mitmproxy, noticed the request header is malformed, doing Authorization: Basic with some junk base64 encoding after.

Okay I think I've worked it out, https://github.com/ezhov-evgeny/webdav-client-python-3/blob/develop/webdav3/client.py#L217 causes the headers added to be overridden.

If I change https://github.com/ezhov-evgeny/webdav-client-python-3/blob/develop/webdav3/client.py#L180 to be a different header from Authorization, it's injected fine.

Deleting https://github.com/ezhov-evgeny/webdav-client-python-3/blob/develop/webdav3/client.py#L217 allows bearer tokens to work if I change https://github.com/ezhov-evgeny/webdav-client-python-3/blob/develop/webdav3/client.py#L217 to Authorization: Bearer instead of Authorization: OAuth

[danielloader]

Created a proof of concept PR, works for me but would appreciate it being looked at as someone new to python.

#42

[ezhov-evgeny]

Merged into the develop branch. It will be published in version 3.14.1