Comments (2)
A few implementations come mind
- Inject shell with env override for testing only
class Shell:
def __init__(..., testing=true, testing_env_defaults={}):
self.env_defaults = testing_env_defaults if testing else {}
-
Use https://pypi.org/project/pytest-forked/
Then,os.environ
pollution isolated. Kinda just a hack... -
Plumb env thru
<command>.main(env={...})
Is this necessary? I don't see a use case of injecting env var other than testing.
WDYT?
from ghstack.
Is this necessary? I don't see a use case of injecting env var other than testing.
Isn't one use case good enough? :)
from ghstack.
Related Issues (20)
- Would it be possible to turn this into a gh extension? HOT 1
- Update PR description when rewording a commit on the stack HOT 1
- Permission denied to create PR via ghstack HOT 3
- Hitting github rate limits HOT 2
- ghstack is not compatible with git-2.17 (default for Ubuntu-18.04) HOT 2
- ghstack can be put into a bad state if PR is not ready to merge HOT 1
- typed-ast doesn't build on python 3.11 HOT 4
- Hitting GitHub API limits
- Why can't the base of the stack be the actual main branch? HOT 7
- Problem when tree doesn't change but commit structure has changed HOT 2
- Unpin `importlib_metadata` requirement? HOT 1
- Set assignee/reviewers, maybe based on commit message? HOT 1
- Consider using click for CLI/argument parsing? HOT 1
- ghstack land can land a stack you didn't specify if they share branches HOT 1
- ghstack checkout should not require creds
- `git rev-list` failed when updating stack HOT 4
- Fail to find ~/.ghstackrc on Windows
- Beginner question: how to get ghstack alias? HOT 3
- ghstack cherry-pick HOT 1
- ghstack crashing nondeterministically HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ghstack.