Comments (2)
I was wondering if there is a (technical) reason that the ghstack info is inserted above the commit message?
There is no technical reason. An aesthetic reason for placing it up top is when you navigate between PRs, the stack list stays at a fixed position (like a menubar). If you want to add a config to toggle it, I guess it's OK; it doesn't seem like the payoff is that great though, but it's pretty simple.
And I was curious if amending the local commit message with remote changes has come up in the past? The use case here is that I/we often add screenshots to a commit on github.com directly. When I update the commit by running ghstack again, the remote edits are overwritten.
Ah yes, this should exist as a feature, it just hasn't been written. Please implement it as ghstack sync [--stack]
(stack argument to update all commits in your stack).
from ghstack.
Duping it as #67
from ghstack.
Related Issues (20)
- ghstack crashing nondeterministically HOT 2
- Compatibility with private GHE repos? HOT 16
- Update only the top PR in stack HOT 2
- Sync updates to head to orig HOT 1
- fatal: ambiguous argument 'origin/gh/XXX/YYY/orig': unknown revision or path not in the working tree.
- ci: tests fail on `windows-latest` with Python `3.11` HOT 1
- incompatible with https cloned repo HOT 1
- Many tests fail on Windows HOT 2
- Make github oauth flow easier to do
- Make github_url setting less error prone for OSS users
- ghstack land does not use most up to date PR description
- Failures in GH Action jobs are not obvious HOT 1
- ghstack land failing with exit code 1 HOT 1
- ghstack 0.9.0 not working for private repos HOT 3
- Base branch commit has no parent commits set HOT 4
- Summary of changes is printed in reverse order of what it should be
- ghstack land merges PR to base branch not upstream main HOT 2
- Couldn't determine repo owner and name from url HOT 1
- --no-skip doesn't work anymore HOT 2
- `ghstack land` doesn't work on private non-pro repositories HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ghstack.