GithubHelp home page GithubHelp logo

Comments (7)

F2 avatar F2 commented on August 30, 2024 3

you could probably just make a timer to do all the work <tv_delay> + 5 seconds after the game_over event lol

This doesn't solve mid-game uploads. If we wait 90 seconds, it would lag for the players on the server.


you would have a better time doing it in C++ as an extension

Unless there is a default extension which can already do this, it would require every server owner to install an extra extension. I would rather not require that. (And besides, I wouldn't want to develop and maintain an extension.)


alternatively you could write (flush) the log every x seconds but i dont know if that would actually be a good idea, might introduce microstutters

The issue is not writing the log, but the file operations happening at the time of upload.


I'm not sure the stutters are still happening. Last match I watched I couldn't find them. Would be worth recreating them to make sure that it's a real thing still

The stutters have always been there, and it is easy for me to recreate them on my own machine.

I have worked on a fix that will reduce the risk of stutters. Here you can see it in action - there is a clear stutter 1 second into the video, which is not visible with the new plugin.

Once I have finished testing, I will release it. (#24)

from f2s-sourcemod-plugins.

sapphonie avatar sapphonie commented on August 30, 2024 1

image

from f2s-sourcemod-plugins.

F2 avatar F2 commented on August 30, 2024

The stuttering is not related to uploading, since that is indeed done in a background thread. It is related to some of the file operations being done by the plugin. I am looking into splitting the workload into smaller chunks, to avoid stutters.

from f2s-sourcemod-plugins.

sapphonie avatar sapphonie commented on August 30, 2024

you could probably just make a timer to do all the work <tv_delay> + 5 seconds after the game_over event lol

that would make it take 90 seconds to get logs uploaded but also like, whatever? definitely an easier solution than setting up threads or async bullshit in sourcepawn, you would have a better time doing it in C++ as an extension

from f2s-sourcemod-plugins.

sapphonie avatar sapphonie commented on August 30, 2024

alternatively you could write (flush) the log every x seconds but i dont know if that would actually be a good idea, might introduce microstutters

from f2s-sourcemod-plugins.

tommy-mor avatar tommy-mor commented on August 30, 2024

I'm not sure the stutters are still happening. Last match I watched I couldn't find them. Would be worth recreating them to make sure that it's a real thing still

from f2s-sourcemod-plugins.

sapphonie avatar sapphonie commented on August 30, 2024

phenomenal work

from f2s-sourcemod-plugins.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.