Uncaught TypeError: Argument 1 passed to FaaPz\PDO\DatabaseException::__construct() must be of the type string, null given about pdo

[kwhat]

How did you construct the Database object? I suspect you inadvertently passed null instead of the DSN.

[nixoncode]

I have the database object initialized correctly, other queries are running well

[kwhat]

Maybe a basic example of how to duplicate the problem would help me understand what is happening.

[nixoncode]

I somehow managed to fix it by using date() function instead of Faapz new Raw('NOW()')

$this->db->update(['last_seen' => date('Y-m-d H:i:s')])
                ->table('users')
                ->where(new Conditional('id', '=', 1))
                ->execute();

The initial query was like this

 $this->db->update(['last_seen' => new Raw('NOW()')])
                ->table('users')
                ->where(new Conditional('id', '=', 1))
                ->execute();

how can I use MySQL's now Function without using the PHP date?

[nixoncode]

Maybe a basic example of how to duplicate the problem would help me understand what is happening.

the queries above can help?

[kwhat]

Yes that helps, I will need to do a little testing on my side. I will get back to you shortly.

[kwhat]

Hm, so I noticed that you are getting a DatabaseException so I think you are using 2.0.0? The DatabaseException was removed in 2.0.1 due to some issues with __toString and throwing Exceptions. Is it possible to try with 2.0.1 and provide a stack trace if it crashes?

[nixoncode]

Am already using 2.0.1

[kwhat]

Raw clause is broken.

[kwhat]

There is also another bug with the list($state, $code, $message) = $stmt->errorInfo(); code in the AbstractStatement i'll take a look at it for 2.1.

[kwhat]

Quick question, I presume you are using PDO::ATTR_ERRMODE => PDO::ERRMODE_SILENT or PDO::ERRMODE_WARNING. How do you check for errors in your code? How would you prefer to check for errors on ->execute() without exceptions? I was thinking though a couple of options for this library: execute could return bool false or return the PDOStatement object where ->errorCode() could be used. Let me know what you think would work best.

[kwhat]

Fix:

diff --git a/src/Statement/Update.php b/src/Statement/Update.php
index 345adde..d34de6e 100644
--- a/src/Statement/Update.php
+++ b/src/Statement/Update.php
@@ -72,7 +72,14 @@ class Update extends AdvancedStatement
      */
     public function getValues(): array
     {
-        $values = array_values($this->pairs);
+        $values = [];
+        foreach ($this->pairs as $value) {
+            if ($value instanceof QueryInterface) {
+                $values = array_merge($values, $value->getValues());
+            } else {
+                $values[] = $value;
+            }
+        }
 
         if ($this->where !== null) {
             $values = array_merge($values, $this->where->getValues());

[nixoncode]

Quick question, I presume you are using PDO::ATTR_ERRMODE => PDO::ERRMODE_SILENT or PDO::ERRMODE_WARNING. How do you check for errors in your code? How would you prefer to check for errors on ->execute() without exceptions? I was thinking though a couple of options for this library: execute could return bool false or return the PDOStatement object where ->errorCode() could be used. Let me know what you think would work best.

Am using the Default, I checked the code and saw PDO::ERRMODE_EXCEPTION was already set. I always do this when using raw PDO.

Am currently handling errors by wrapping everything in a try-catch and listen for errors on FaaPz\PDO\DatabaseException I think that works just fine, in the past I would do \PDOException. I think exceptions is the best way to go since PDO does that as well.

[nixoncode]

There is also another bug with the list($state, $code, $message) = $stmt->errorInfo(); code in the AbstractStatement i'll take a look at it for 2.1.

Yes, at times null is returned for the message. I don't know why. I remember making the message nullable on the DatabaseException class

public function __construct(?string $message = '', string $code = 'database_error', Exception $previous = null)
    {
        parent::__construct($mes sage, 0, $previous);
        $this->code = $code;
    }

[kwhat]

I published 2.1 which fixes your issue. I think it has something to do with the mysql pdo driver not having a msg for that particular error code. Either way, DatabaseException has gone away and I simplified a few things to make it easier to work with. Let me know if you run into any other issues.