Circular reference when 'strict: true' in tsconfig.json about modular-forms

[fabian-hiller]

I believe I have fixed the problem with v0.8.4 now. Although File extends Blob, it seems that TypeScript v4.9.3 no longer maps T extends File correctly. I have implemented a workaround for now.

[durandj]

The fix worked, thanks @fabian-hiller !

[ikapo]

Can confirm it fixed it for me as well. Thanks @fabian-hiller for the quick responses and a great library!

[fabian-hiller]

That is interesting. I also have strict set to true. Even in the tsconfig.js of Modular Forms. Does skipLibCheck set to true help maybe? Otherwise, can you send me the link to the Stackblitz project?

[alexss3]

Adding skipLibCheck: false didn't change anything. The Stackblitz I'm referring to is just based on the Solid/Typescript template from their front page, which I downloaded and added the other dependencies/config manually. I could perhaps make a repo with just that if you like.

[fabian-hiller]

false is the default value. Please test it with skipLibCheck: true. Yes a repo would be helpful.

[alexss3]

Sorry, meant to say true when I wrote that. In any case, I tried it with both true/false and neither worked. Here is a repo of the sample project. You should see the error in App.tsx and when you change strict: true in tsconfig.json the error should go away.
https://github.com/alexss3/solid-modular-forms

[fabian-hiller]

I could not reproduce it. No error occurs for me. I cloned the repository and strict was already true. Maybe try to update your packages to the latest version.

[alexss3]

Ok, I just tried it on my personal laptop and got the same error message. I probably have a very similar setup with VS Code and could be the cause, though I'm not exactly sure what I should look for to find the root cause of it.

On my laptop I disabled a couple extensions [Javascript and TypeScript Nightly, Prettier] and saw it go away, but can't reproduce the symptom to know which one it was. On my other machine I tried the same and cannot get the error to go away at all, even after disabling all VS Code extensions. Very strange indeed.

[fabian-hiller]

@alexss3 do you have any updates for me? Were you able to solve the problem?

[ikapo]

I am also encountering this problem, but on Emacs (using the vscode typescript LSP server though).
skipLibCheck: true is also enabled in my setup

[fabian-hiller]

I will look at the problem again. It's just difficult because I can't reproduce it properly.

[durandj]

I had the same issue and adding "skipDefaultLibCheck": true to my tsconfig.json fixed it for me. 🤷‍♂️

[fabian-hiller]

I have made a few changes to the types and tried to solve the problem. Since I still can't reproduce it on my computer, I don't know if the changes were successful. Can you upgrade the library to v.0.8.3 and also upgrade TypeScript and check if it is solved. If TypeScript is installed globally, I also recommend updating the global version.

[durandj]

I updated to the latest version of Typescript and @modular-forms/solid and have skipLibCheck set to true and skipDefaultLibCheck set to false and the problem still exists.

I'll try and create a repo that reproduces the issue and add it to Github tomorrow.

[fabian-hiller]

After some investigation, I suspect that this is a problem that only exists with older TypeScript versions. The editors do not always use the version specified in package.json by default. In VS Code, for example, you can click "{}" in the status bar at the bottom of the screen to select the version. Can you check which version is shown there and if the error messages disappear when you upgrade to TypeScript v4.9.3?

[durandj]

It's definitely not the Typescript version. It took me a bit to reproduce but I eventually got it with a minimal case.

The problem is if you have @types/node installed then the type of console.log becomes a Blob and that triggers an infinite loop on the ValuePath and ValuePaths types.

You can find my reproduction here: https://github.com/durandj/module-forms-solid-4-repro

The real fix in my case was to replace the onSubmit handler which I had set to console.log for testing with literally anything else lol.

[fabian-hiller]

@durandj for me, no error occurs when I clone your repository and install the npm packages.

[durandj]

Did you run `pnpm run lint`?

…

On Tue, Nov 29, 2022, 09:10 Fabian Hiller ***@***.***> wrote: @durandj <https://github.com/durandj> for me, no error occurs when I clone your repository and install the npm packages. — Reply to this email directly, view it on GitHub <#4 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVE7DR73BZ6BOHB3KDN5STWKYMHXANCNFSM6AAAAAASIY7C34> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[fabian-hiller]

You are right, when running pnpm run lint the error occurred. I have found a way to reproduce the problem. When I click on "{}" in the status bar in VS Code, TypeScript v4.8.4 is displayed and no error occurs. If I switch to v4.9.3 I get the error. When I downgrade TypeScript with pnpm i -D [email protected] and then run pnpm run lint the error does not occur.

If it's due to the new TypeScript version, that also explains why the problem has only been occurring for a few days. In this case, I recommend downgrading to v4.8.4 until there is a solution to the problem.

[fabian-hiller]

Thank you for your help!