GithubHelp home page GithubHelp logo

Comments (11)

fabian-hiller avatar fabian-hiller commented on May 27, 2024 1

Thank you very much for your feedback! I mainly use the dark theme, so I focused on that during development. I will take another look at the colors of the light theme. I will give you an update in the coming days.

from vscode-pace-theme.

fabian-hiller avatar fabian-hiller commented on May 27, 2024 1

Hey @jahirfiquitiva, I added a Light+ theme with higher contrast. Once you update the theme to v0.2.0, it should show up in the list. Do you think the contrast is sufficient? Feel free to leave me feedback on it here!

from vscode-pace-theme.

fabian-hiller avatar fabian-hiller commented on May 27, 2024 1

I made the colors a bit darker again and added a new theme called Light++. Feel free to give me feedback compared to the Light+ theme.

I also experimented with the background color. However, I didn't like the results, so I stuck with the white background. If you want to customize the theme to your needs, you can create a fork or just copy the code.

from vscode-pace-theme.

fabian-hiller avatar fabian-hiller commented on May 27, 2024 1

Let's keep for now the current names. Thanks again for your feedback! 🚀

from vscode-pace-theme.

jahirfiquitiva avatar jahirfiquitiva commented on May 27, 2024

@fabian-hiller awesome, thanks!

from vscode-pace-theme.

jahirfiquitiva avatar jahirfiquitiva commented on May 27, 2024

@fabian-hiller thanks for the update. I checked and all colors contrast ratio still fail except for the red and purple shades.

Anyway, the texts are easier to read now, so it's definitely an improvement, thanks!

Btw, I found another issue with unused (?) variables or lines ... the text is even less visible and much harder to read 😕 it would also be great if you could take a look at it.

Shot 2022-09-06 at 16 42 52@2x

from vscode-pace-theme.

fabian-hiller avatar fabian-hiller commented on May 27, 2024

Thanks again for the feedback! Would you recommend raising the contrast another notch? In this case, the colors will continue to lose some of their "color".

Btw, I found another issue with unused (?) variables or lines ...

Thank you for pointing that out, of course it shouldn't be like that. I will have a look at it in the next few days.

from vscode-pace-theme.

jahirfiquitiva avatar jahirfiquitiva commented on May 27, 2024

@fabian-hiller yeah, I would recommend making the colors a bit darker. Another thing maybe you could try is not using white for the background for rather a light shade of gray like #FAFAFA or #ECEFF1 🤔

from vscode-pace-theme.

jahirfiquitiva avatar jahirfiquitiva commented on May 27, 2024

@fabian-hiller Thank you so much! it looks much better... do you think it would be possible to keep both Light+ and Light++? That would allow people to choose the one they like better or fits better to their visual conditions 🤔

from vscode-pace-theme.

fabian-hiller avatar fabian-hiller commented on May 27, 2024

Sorry for the late feedback. Until version 1.0, I'm open to experimentation. Can you think of a better name for the themes that draws attention to the difference in contrast?

from vscode-pace-theme.

jahirfiquitiva avatar jahirfiquitiva commented on May 27, 2024

@fabian-hiller i'm bad at naming things 😆 but maybe:

  • Light+ -> High Contrast
  • Light++ -> A11y Compliant
    ?

from vscode-pace-theme.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.