GithubHelp home page GithubHelp logo

Comments (3)

i001962 avatar i001962 commented on May 27, 2024

@fabien0102 I may have just messed up by pushing a new package-json to master in an attempt to resolve this issue. I should have created a pull request. Sorry if this causes you a headache.

the xo test shows a build failing.
Warning: React version not specified in eslint-plugin-react settings. See https://github.com/yannickcr/eslint-plugin-react#configuration.
The react/jsx-space-before-closing rule is deprecated. Please use the react/jsx-tag-spacing rule with the "beforeSelfClosing" option instead.
gatsby-node.js:40:1
βœ– 40:1 Expected indentation of 10 spaces but found 8. indent
βœ– 83:1 Expected indentation of 10 spaces but found 8. indent

I'm looking into this and will attempt to correct with PR. Sorry about this. Feel free to rollback the push I accidentally made if that's easier.

from gatsby-starter.

fabien0102 avatar fabien0102 commented on May 27, 2024

@i001962 Don't worry, it happens, it's strange that travis doesn't complain πŸ˜…

If you open a PR to fix this, I will approve it and merge it with pleasure :)

Note: Normally we have merged the next branch in master, are you talking about master or I am missing something πŸ€”

from gatsby-starter.

i001962 avatar i001962 commented on May 27, 2024

I had originally opened this issue in the next branch but ran into on master after the merge with next. So I tried to fix it but caused the Travis failure. I can’t seem to figure out how to resolve that.

from gatsby-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.