GithubHelp home page GithubHelp logo

Comments (4)

Linguardium avatar Linguardium commented on August 19, 2024 2

if you remap the entire game to mojmap in production, and then try to load mods that are mapped to intermediary (the production output state), that will never work. there is a reason floader remaps the game to intermediary and loom remaps mods to intermediary at build time. if you are deviating from that to force some other mapping, you need to go all the way and remap everything not just the base game

from fabric-loader.

Chocohead avatar Chocohead commented on August 19, 2024 1

Loader expects AWs to be in the target namespace:

accessWidenerReader.read(reader, FabricLauncherBase.getLauncher().getTargetNamespace());

Knot presumes this is named in dev or intermediary out of dev:

public String getTargetNamespace() {
// TODO: Won't work outside of Yarn
return IS_DEVELOPMENT ? "named" : "intermediary";

Loader only remaps AWs when in dev, and even then only from intermediary to the target namespace (i.e. Yarn).


official as a namespace is effectively a Minecraft specific invention; if you search for it, the only references are in MinecraftGameProvider and an old overload in GameProviderHelper, all in the context of remapping the original game jar. Regardless to whether your GameProvider remaps the game jar, the target namespace is taken as intermediary (out of dev).

from fabric-loader.

modmuss50 avatar modmuss50 commented on August 19, 2024 1

I think this is a valid issue, currently both loom and loader cheat a bit when intermediaries arent present as use intermediary as the namespace, this is mostly becuase the work to support this hasnt been done. All of the loader APIs should support this just fine.

from fabric-loader.

halotroop2288 avatar halotroop2288 commented on August 19, 2024

Soooo... call it what it is. dev or production

Cause development isn't always "named" and production isn't always intermediary. It seems like that is the only necessary distinction here.

from fabric-loader.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.