Comments (15)
I have a proof of concept of this working: https://twitter.com/dan_abramov/status/773799004878565376.
Iβd like #419 to land first, and then I can add this.
from create-react-app.
I agree we should print the terminal output in an overlay if the compilation fails.
@glenjamin worked on https://github.com/glenjamin/webpack-hot-middleware that does this, but IIRC it had some other problems.
So Iβd like to see this as a feature, but probably implemented as a custom client instead of the one that ships with WebpackDevServer.
from create-react-app.
I'd happily accept any PRs / specific fixes for problems in hot-middleware, it already has a custom HMR client and is widely used.
You are of course free to port/fork, but it'd be good to share if possible.
from create-react-app.
Could you make it not depend on polyfill in IE? As I recall this was the biggest issue.
from create-react-app.
(Not saying itβs the only one tho. If you could make a PR porting from WDS to the middleware it would be easier to find other issues.)
from create-react-app.
One thing I love about Brunch is that in case of error it will show a system notification, no config required. :w
and seeing an error notification, it's easier to go to another terminal tab and see the stack trace, than to cmd+tab to the browser after saving a few files only to then spot an error.
from create-react-app.
Sounds interesting. Perhaps we should do that. Want to take a stab at PR?
from create-react-app.
There even seems to be a webpack plugin for that already https://www.npmjs.com/package/webpack-error-notification
from create-react-app.
Which doesn't work on Windows, though.
Sure, I'll take a stab at it tomorrow!
from create-react-app.
The options for this are either plain WebSocket, which is IE10+ or a lib that magically deals with fallbacks - which would be weightier.
Any thoughts on what is preferable?
On 22 Jul 2016, at 20:31, Dan Abramov [email protected] wrote:
Could you make it not depend on polyfill in IE? As I recall this was the biggest issue.
β
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
from create-react-app.
What was the motivation behind not using WebSockets?
from create-react-app.
Ironically I thought it'd be simpler & more reliable!
On 22 Jul 2016, at 23:17, Dan Abramov [email protected] wrote:
What was the motivation behind not using WebSockets?
β
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
from create-react-app.
(Submitted #131 to add notifications)
from create-react-app.
#419 landed :)
from create-react-app.
I was just looking into it. π
from create-react-app.
Related Issues (20)
- Snyk Package Analysis - Improper Input Validation Vulnerability HOT 1
- Snyk Package Analysis - Prototype Pollution Vulnerability HOT 1
- Snyk Package Analysis - Missing Release of Resource after Effective Lifetime Vulnerability HOT 2
- Docs: code splitting links to old/incorrect React page
- Create issue Facebook app HOT 3
- Uncaught ReferenceError: process is not defined at emitReadable (_stream_readable.js:529:1) at onEofChunk (_stream_readable.js:506:1) at readableAddChunk (_stream_readable.js:255:1) at Readable.push (_stream_readable.js:241:1) at index.js:423:1 emitReadable @ _stream_readable.js:529 onEofChunk @ _stream_readable.js:506 readableAddChunk @ _stream_readable.js:255 Readable.push @ _stream_readable.js:241 (anonymous) @ index.js:423 Show 5 more frames Show less
- Run `npm install` in `D:\git\r\`. HOT 1
- Hi gaearon
- Hebosho911
- Could the community save this dead project? HOT 4
- pateknuk
- use parameter decorator HOT 5
- My React app not installing HOT 3
- create-react-app problem
- Can't start creat react app HOT 1
- Facing an error to install firebase HOT 1
- It is intentionally verbose. Otherwise there is a risk of accidentally exposing a private key on the machine that happens to have the same name.
- npx create-react-app HOT 2
- Dependency Packages introduced vulnerabilities associated with react-scripts 5.0.1
- I am not able to run the project i have uploaded my issue so please help me or provide me a updated documentation for this
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from create-react-app.