GithubHelp home page GithubHelp logo

Comments (10)

slorber avatar slorber commented on June 18, 2024 1

Apparently this warning was also there in v18.2 😅

Will be fixed in v3.3.1 thanks to #10103

from docusaurus.

slorber avatar slorber commented on June 18, 2024

This is fixed for the next release, planned for tomorrow.

Until then you can downgrade to React 18.2 which does not have this warning

#3841 (comment)

from docusaurus.

pixelass avatar pixelass commented on June 18, 2024

@slorber thank you for the fast response. In this case please feel free to close this issue.
I can hide error logs in the console if they annoy me.

No worries. These things happen in this fast evolving landscape.

But tomorrow it'll be fixed.. Promise? No Backsies 🤣

from docusaurus.

slorber avatar slorber commented on June 18, 2024

Yes it will be fixed today, working on it right now. (#10101)

Note you are using Chrome 89, a quite old version that's probably why StackBlitz does not work.


Warning: You are calling ReactDOMClient.createRoot() on a container that has already been passed to createRoot() before. Instead, call root.render() on the existing root instead if you want to update it.

I am unable to reproduce this warning and did not do anything to fix it.

If you can still reproduce it, please tell me the exact steps, including how you run Docusaurus and which page exactly you see the error on (including how you opened that page, between a browser page load or a navigation action). This issue does not contain those details atm but they are important to figure out problems.

from docusaurus.

pixelass avatar pixelass commented on June 18, 2024

@slorber thx for the update. I can confirm that most warnings are gone on v3.3.0 ❤️.

I still get this warning ReactDOMClient.createRoot(), it happens on hot-reloading.

image

I'll try to reproduce it on a clean MVP project and send you the github repo if I can reproduce it there.

Thanks so far. Super helpful.

from docusaurus.

pixelass avatar pixelass commented on June 18, 2024

@slorber
I just tested it in a completely clean instance (no modifications).
You can just do the following:

  • run npx create-docusaurus@latest docusaurus-demo classic
  • update to react 18.3.1
  • update to docusaurus 3.3.0
  • run npm start
  • open web console
  • go to index.tsx and change adjust the text
  • see console error

If it helps, I can upload the repo but the steps above should be super clear and probably just as easy as cloning a repo with those adjustments already in place.

from docusaurus.

pixelass avatar pixelass commented on June 18, 2024

@slorber BTW. I am not using v89 of chrome 🤣 that is the example that was provided by your issue template. I just added v20 of Node after the colon and did not mention the chrome version at all as it was irrelevant to this issue.

Environment name and version (e.g. Chrome 89, Node.js 16.4): Node v20
Operating system and version (e.g. Ubuntu 20.04.2 LTS): Unrelated (using Windows 11)

I guess you are referring to this (e.g. Chrome 89, Node.js 16.4)

Maybe it is wiser to put the example text in an HTML comment instead of parentheses, to prevent this misunderstanding in future bug reports.

from docusaurus.

pixelass avatar pixelass commented on June 18, 2024

https://github.com/pixelass/docusaurus-bug-report-000001

MVP reproduction for the issue on hot-reloading

You can just do the following:

  • clone the repoitory
  • run npm i or yarn
  • run npm start or yarn start
  • open web console
  • go to index.tsx and change any text and save
  • see console error

from docusaurus.

slorber avatar slorber commented on June 18, 2024

THanks yes, I can reproduce now.

I'll have to publish a v3.3.1 soon then 😅

from docusaurus.

pixelass avatar pixelass commented on June 18, 2024

Community is everything 😄

from docusaurus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.