GithubHelp home page GithubHelp logo

Comments (6)

Josh-Cena avatar Josh-Cena commented on April 29, 2024

Hi! You cannot use useBrokenLinks in a plugin file. Plugins are run in Node. You can only use it in a theme component. I think we should explain better how to register anchors directly in the plugin.

from docusaurus.

danielspofford avatar danielspofford commented on April 29, 2024

Appreciate your confirmation @Josh-Cena - I figured as much after continuing my efforts.

I think we should explain better how to register anchors directly in the plugin.

If this is possible can you please point me at anything (docs/source examples/whatever) that would shine some light on how I do that? Exactly what I'm after.

from docusaurus.

Josh-Cena avatar Josh-Cena commented on April 29, 2024

I somewhat suspect that it's impossible, since right now only the rendering code reports back valid anchors. I'll let @slorber answer though; if it's really not achievable, maybe we should have an API. It sounds useful for plugins that create external HTML pages that don't use Docusaurus themes.

from docusaurus.

danielspofford avatar danielspofford commented on April 29, 2024

I suspect that as well.

It sounds useful for plugins that create external HTML pages that don't use Docusaurus themes.

Yeah that is my exact use case. Was trying to work around rohit-gohri/redocusaurus#321.

The problem for me is that:

  • In a plugin:
    • I have access to the external HTML page's content (fs.reads in postBuild), and I can get anchors I would like to collect from it, but I cannot tell docusaurus about those anchors as discussed in this issue.
  • In a theme component:
    • I can tell docusaurus about anchors (via useBrokenLinks), but I do not have access to the external HTML page's content, so I cannot get anchors I would like to collect from it.

Just to see if it was possible, I tried to: generate the anchors in the plugin, stick them in global data, and then access them from a theme component so that I could useBrokenLinks. But there is an order of operations problem:

  • In order for my plugin to generate the anchors, the external HTML must already exist.
  • External HTML will only exist from my plugin's POV at time of postBuild.
  • setGlobalData is only available at time of contentLoaded, not in postBuild, so I cannot pass the anchors through because by the time I get them, I cannot setGlobalData.

Regardless of the order of operations problem, it feels wrong to me to serialize and pump that data around in that manner. Seems like allowing for that in plugins like you say would be very nice for this use case.

from docusaurus.

slorber avatar slorber commented on April 29, 2024

@danielspofford it would greatly help me if you provided a minimal repro that reports broken anchors that you would like to solve. This way, I could see how to fix that repro so that those anchors do not get reported anymore.

Your repro just shows an attempt to import a React hook in Node.js code, something that is illegal). I can't act on it, and fix the problem, because the problem is not showcased in the first place. Show me the problem and I'll help fix it. Seeing a runnable sandbox of your setup that actually reports wrong broken anchors is more helpful than explaining things in text form.

from docusaurus.

danielspofford avatar danielspofford commented on April 29, 2024

@slorber here is a minimal repro that reports broken anchors that I would like to solve.

https://codesandbox.io/p/devbox/distracted-cache-7xxfh5

example output image

from docusaurus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.